Genesis
Genesis copied to clipboard
[Bug]: discarded calculations in get_links_acc
trafficstars
Bug Description
I'm not sure if this was just for debugging when originally writing the PR, and simply forgotten to delete, or an oversight and calculation bug now, but noticed it and want to check. In the for loop of _kernel_get_links_acc():
https://github.com/ethz-asl/omav_genesis/blob/090ad078151c6a8c14a2d37e1682c4fb544ea327/genesis/engine/solvers/rigid/rigid_solver_decomp.py#L4096-L4099
final_acc = acc + correction
final_acc = self.links_state[i_l, i_b].cdd_vel
This came in with #451 @YilingQiao @zswang666
Steps to Reproduce
Nothing to reproduce, is in code.
Expected Behavior
Should return the current link acceleration.
Screenshots/Videos
No response
Relevant log output
Environment
--
Release version or Commit ID
https://github.com/Genesis-Embodied-AI/Genesis/commit/135f9a0aed652d1d1facf2f3c9c612898300fa41
Additional Context
No response