gateplugin-LearningFramework icon indicating copy to clipboard operation
gateplugin-LearningFramework copied to clipboard

Scaling does not work any more

Open johann-petrak opened this issue 7 years ago • 1 comments
trafficstars

This is probably a result of re-factoring so that the engine now decides on which corpus representation to use. But this means the engine has to know how to initialize the corpus representation.

Instead of passing around yet another parameter in all those methods, the idea is to set the scaling method as part of constructing the feature info or set it once the feature info has been created. The feature info gets passed to the corpus representation, so the scaling info could get set from there. To make this clear we should remove the constructor parameter for the scaling method alltogether.

johann-petrak avatar Sep 06 '18 13:09 johann-petrak

Fixed in principle, but the whole scaling approach needs to get rivisited #85

johann-petrak avatar Sep 06 '18 16:09 johann-petrak