JAX-GalSim

JAX-GalSim copied to clipboard

This issue is to discuss the various aspects of the roadmap necessary to reach a minimal implementation following the guidelines of the [design document ](https://docs.google.com/document/d/1NalCc_5dc3Z8F4q37y-RsJS_mr9gzvfyANb2PYUpsb4/edit?usp=sharing) and reaching our initial target...

EiffL

Right now when photons are added to sensors, it is done inside of a JITed function. Thus any internal state in the Sensor is not automatically propagated back out. We...

beckermr

The k-space drawing for the sinc interpolant is really slow. We should figure out why and try to fix it.

beckermr

Quintic interpol: which one?

1

Well by this question, I'm revisiting the quintic polynomial kernel. I will let you know why and what is my conclusion or question soon.

jecampagne

Open question why this is happening, @EiffL found this small effect that might be point to a bigger problem. For now removed from #42 Specifically the functions in `jax_galsim/core/draw.py`

ismael-mendoza

All tests are in `test_moffat.py` from Galsim. - [ ] `test_moffat`, move `do_shoot` to the bottom of the tests to activate some more in this block of tests - [...

ismael-mendoza

@rmjarvis mentioned this issue might be useful: - https://github.com/GalSim-developers/GalSim/issues/566 And this math stackexchange question: - https://math.stackexchange.com/questions/3808975/is-there-an-analytic-formula-or-good-fitting-function-for-the-hankel-transform-o

ismael-mendoza

consistent wrapping for docstrings

1

there are different methods and classes that wrap the Galsim API documentation, but some that don't and copy paste instead. I think we should change the code to use wrapping...

ismael-mendoza

Moffat maxK computation : Galsim 2.4-> 2.5

1

This issue is to keep in mind that the maxK computation of Untruncated Moffat is the 2.4.x versions of Glasim will be changed in the 2.5.x versions. The JAX-Galsim Moffat...

jecampagne

immutability in Image class

1

Reposted from #16 from @EiffL > There are some questions about this though. galsim.Image are mutable objects, which really does not play nicely with JAX, it is simply not possible...

ismael-mendoza