code-gov-api icon indicating copy to clipboard operation
code-gov-api copied to clipboard

Scrub null json fields during harvesting

Open froi opened this issue 7 years ago • 4 comments

This issue references https://github.com/GSA/code-gov-web/issues/560, created by @USDOJ-FSCP.

Original issue text:

At DOJ we are using a SharePoint solution that is not feature-rich when it comes to character level text processing. We are collecting code.json entries using an embedded forms feature in SharePoint, but we have limited ability to do anything that SharePoint doesn't provide some sort of plug in for. There is no readily available scripting tool within our reach to manage logic.

Because of that we have allocated a certain number of fields to various array values like keyword, language and so forth. So we have room on the UI for up to 5 keywords, and if a user only fills three of those blanks, the json file will have two null fields (,"") . This causes the harvester to post blank values, little null icons where the key words would be displayed. Its my thinking that a smarter harvester, one that discards null fields, would be a better investment than 10 - 15 improved json generating tools across the government that all will need to have logic that strips null fields.

froi avatar May 10 '18 22:05 froi

I don't quite follow the issue. I would like to have a conversation about this to go over what exactly is the problem is.

CC. @RicardoAReyes @USDOJ-FSCP.

froi avatar May 11 '18 14:05 froi

Sure, I’m working from home, can you call me at

David Landeck Service Engineering Staff US Dept. of Justice [email protected]

From: Froilan Irizarry [email protected] Sent: Friday, May 11, 2018 10:43 AM To: GSA/code-gov-api [email protected] Cc: Landeck, David (JMD) [email protected]; Mention [email protected] Subject: Re: [GSA/code-gov-api] Scrub null json fields during harvesting (#220)

I don't quite follow the issue. I would like to have a conversation about this to go over what exactly is the problem is.

CC. @RicardoAReyeshttps://github.com/RicardoAReyes @USDOJ-FSCPhttps://github.com/USDOJ-FSCP.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/GSA/code-gov-api/issues/220#issuecomment-388384676, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Aj9IRNJx31TzFVwLpfxkP7Iu_mmaajjDks5txaOBgaJpZM4T6p1X.

USDOJ-FSCP avatar May 11 '18 14:05 USDOJ-FSCP

I've removed the phone numbers from your comment @USDOJ-FSCP You might want to delete the numbers from the signature when replying to emails from Github from your email client. These are public šŸ˜„

I'm at a conference but will carve out some time to make the call. If I can't I will post another comment.

froi avatar May 11 '18 15:05 froi

@USDOJ-FSCP Sorry that this has fallen through the cracks. I'd like to retake this. I'll send you an email directly.

froi avatar Jul 31 '18 17:07 froi