Explore country page: Combine results from Categories/Hazards and Country Groups filters

[CIMAManuel]

Categories/Applicability filter and Country Group must work togher.

[thom4parisot]

For the record, this bug is present because #326 has been merged in spite of this change being asked for. I mentioned I was looking into it, clarifying whether it required "more code and no API change" or "no code change and an API change" (making /api/country/ on par with /api/country_score/ filters)

An issue which happen during an iteration can only be scheduled for a next iteration unless it is operation critical (eg: Global data page not working).

[pzwsk]

Ok thanks @oncletom

I recommended @CIMAManuel to open this issue because I understood it was blocking the deployment of new Country Groups list on Prod.

To me it is not a bug per se but more a clarification/enhancement on how Country Filters should behave that has been overlooked when we defined the issue at first.

Now, I understand this feature is working on Exp FE but I don't know what has been done and how. @CIMAManuel can you explain?

Also, actually I don't understand why this issue would be blocking the use of new Country Groups list? If this not the case, it is less urgent then.

Could you please continue discuss it here?

Many thanks

[CIMAManuel]

@pzwsk exp has a old FE version, I updated it to test my changes to Explore countries but these changes was revert by @oncletom so I think exp is not to consider now. EXP is only a "test area". I activate bug label because I thought this issue was a request and to remind that this page is "incomplite" because last PR was approved for urgency and I think this issue is not basic for deploy. So, we can do that (if necessary) in next iteration. Let me Know.

Thanks

[pzwsk]

Ok thanks,

let's discuss this on Monday then.

On Fri, Nov 30, 2018 at 1:00 PM Cavallaro Manuel [email protected] wrote:

@pzwsk https://github.com/pzwsk exp has a old FE version, I updated it to test my changes to Explore countries but these changes was revert by @oncletom https://github.com/oncletom so I think exp is not to consider now. EXP is only a "test area". I activate bug label because I thought this issue was a request and to remind that this page is "incomplite" because last PR was approved for urgency and I think this issue is not basic for deploy. So, we can do that (if necessary) in next iteration. Let me Know.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GFDRR/open-risk-data-dashboard/issues/338#issuecomment-443183095, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRKx-3xc1k8O7VDNOe95CEPoXJxnGpCks5u0R3MgaJpZM4Y7URQ .