GCHQDeveloper314

Results 66 comments of GCHQDeveloper314

To help with completing this ticket I've had a look through the codebase for where these improvements can be made. Simplification of `assertEquals(Lists.newArrayList())`. Using `grep -rFIl "assertEquals(Lists.newArrayList" .` finds: ```...

See [my comment in 2812 ](https://github.com/gchq/Gaffer/issues/2812#issuecomment-1618862030)(closed duplicate of this) for some more info on this.

The idea for mapping static Accumulo table names to renamable GraphIds is how this should have been done originally. However making this change now would be disruptive and would require...

The historic comments by @m55624 above (new ordered methods) relate to the branch `gh-1804-SchemaElementDefinition-method-signatures`, but this was never merged in and these changes have not been applied. In Gaffer there...

> The motivation behind all this is a need to be able to mark records for deletion. The process above is a scary way of going about this. Instead we...

An additional problem with use of schemas is that various unit tests in `Graph` and `Store` make the assumption that the schema used to create a store will be the...

To clarify, the other PR suppressed the garbage collection warning, it did not fix the cause. This issue would include fixing the root cause of that error and then removing...

The repeated Spring banners can be disabled - [see Spring docs](https://docs.spring.io/spring-boot/docs/2.1.9.RELEASE/reference/html/boot-features-spring-application.html#boot-features-banner).

Closed by #2915 The solution for this was to remove the `getTraits` method from Gaffer and use the operation instead, combined with removing the `DYNAMIC_SCHEMA` trait.

I have never seen this error. @GCHQDev404 @t92549 - Have you seen this at all? If not I think this should be closed as no longer an issue.