fusionauth-site
fusionauth-site copied to clipboard
FusionAuth
feat(android-sdk): fusionauth android sdk beta blog and site update
This is the first draft for the FusionAuth Android SDK Beta Release.
The fusionauth-site edits and blogpost are from the perspective of releasing a FusionAuth Android SDK Beta, and the status is currently as follow:
- https://github.com/FusionAuth/fusionauth-quickstart-java-android-fusionauth-sdk needs to be renamed to fusionauth-quickstart-kotlin-android-fusionauth-sdk as its written in kotlin
@Aaron-Ritter the file layout should match our other quickstart like this one https://github.com/FusionAuth/fusionauth-quickstart-java-android-native
Having the docker image and kickstart folder in the root and then the complete-application contain the android app.
It might also be simpler to create a new repo with the correct naming.
@Aaron-Ritter the file layout should match our other quickstart like this one https://github.com/FusionAuth/fusionauth-quickstart-java-android-native
Having the docker image and kickstart folder in the root and then the
complete-applicationcontain the android app.
Sure, we can easily change that by moving most of it in to the complete-application sub-directory. From a handling perspective inside Android Studio it was simpler to have the project in the root directory but it should work with the other structure too.
It might also be simpler to create a new repo with the correct naming.
I currently have write access to this https://github.com/FusionAuth/fusionauth-quickstart-java-android-fusionauth-sdk and the android-fusionauth-sdk. so if we could just rename fusionauth-quickstart-java-android-fusionauth-sdk to fusionauth-quickstart-kotlin-android-fusionauth-sdk the access can stay for now as it is without a change required.
I currently have write access to this https://github.com/FusionAuth/fusionauth-quickstart-java-android-fusionauth-sdk and the android-fusionauth-sdk. so if we could just rename fusionauth-quickstart-java-android-fusionauth-sdk to fusionauth-quickstart-kotlin-android-fusionauth-sdk the access can stay for now as it is without a change required.
@Aaron-Ritter
Here is the full docs for quickstarts https://github.com/FusionAuth/fusionauth-example-template/blob/master/QUICKSTART-INSTRUCTIONS.md
For naming this should follow the same, I have put in a request to Change name from fusionauth-quickstart-java-android-fusionauth-sdk to fusionauth-quickstart-kotlin-android-native.
@alex-fusionauth I've already moved the contents of the quickstart and will update the documentation accordingly and request a new review accordingly. We originally based it on it but were modifying it for a potential easier automated release later on but we will cross that bridge when we come to it.
Are you still reviewing the rest of the fusionauth-site PR (Blog/SDK) or do you have additional input i can consider while reworking the stuff related to quickstart?
@alex-fusionauth we are currently working on the FusionAuth 1.50.1 upgrade, we fixed most of it but are still looking into some unexpected behaviour https://github.com/FusionAuth/fusionauth-android-sdk/pull/60.
So if you don't find anything else which needs changing we'd suggest to still wait for the merge of the PR until we fixed the incompatibility with the latest FusionAuth release and created a new version of the SDK.
@alex-fusionauth added a few comments, otherwise mostly merged and updated a few other additional wrong links/references.
The Not authorized issue mentioned by you above is something which we did not experience during our testing (if you checkout the repository and start it in Android Studio it should just work).
Once the new SDK version is released which is at the moment pending on https://github.com/FusionAuth/fusionauth-android-sdk/issues/64, i will fully re-test the quickstart with 1.50.1.
Thanks a lot for the additional review @mark-robustelli I've updated most of your feedback, and as well fixed the styling which was fixed for all previous versions but not 1.51 css. I've updated https://github.com/FusionAuth/fusionauth-android-sdk/?tab=readme-ov-file#release-process making sure the quickstart files are updated with each release.
Overall, I got it running. I could figure out what need to be created where and got it going. It could be because I am not a seasoned Android developer, but it was not always clear to me why I was doing what I was doing. The copy and paste is fine, but I do think there needs to be some explanation.
All thought we based the quickstart on the existing AppAuth one we could go in to more detail. But i strongly suggest to do that in a later step once we have a first v1.0.0 SDK release and rather consider improving the documentation around the SDK first and then reference the documentation from the quickstart.
Also, I see for the blog that you mentioned that you do not create the art work. Do you know if Alex started that process? I can if not.
I dont think he started anything, yes please create it :+1: .