[BUGFIX] Fix Input Offset interactions with Input Window (+ sustains)

[xenkap]

Very odd that this was already done on the opponent's side, but not the Player's.

Does this PR close any issues? If so, link them below.

https://github.com/FunkinCrew/Funkin/issues/3692, https://github.com/FunkinCrew/Funkin/issues/2382

Briefly describe the issue(s) fixed.

Input Windows would not be offset by Input Offset, only Note Judgement would be. This pull request fixes that.

Include any relevant screenshots or videos.

BEFORE:

https://github.com/user-attachments/assets/0b646dc7-d023-4c25-b1c7-cbd233acb484

AFTER:

https://github.com/user-attachments/assets/8536df28-cfc1-4b3a-ba33-a4e816dcae5e

(Recorded on 200ms Input Offset) ~~(side note: can someone make events responsive to your offset ?? the hey animations are playing too early)~~ ignore, use visual offset on negative side to achieve effect

[xenkap]

oops wait wrong implementation? hold on

[xenkap]

my bad, completely correct implementation i just forgot to set my binds

[xenkap]

All good, ready for review :D

[swordcube]

someone please accept this 🙏

[xenkap]

(TL;DR Wondered if this is how Input Offset should function -- offsetting the notes entirely, or if it should instead offset the hit window from the graphic itself. See edit history for details: tested an implementation of it, ran into issues regarding sustains where it was unclear how they should function. A discussion about offsets might be nice?)

[xenkap]

Rebased, squashed commits! Hoping for a re-review like my other offset PR :pray:

[xenkap]

Sorry! Fixed. I got really busy and couldn't really get around to keeping my PRs up-to-date...

[Hundrec]

Thanks! Though I would come back soon to see if the new version's source release creates more conflicts!

[xenkap]

EDIT: when i sent this i was still having trouble compiling the new update. oops

wwow that's one messy rebase! finished, though :] ...but, I'm not really sure if input offset should even work this way...? it works for now, but the way it works it's kind of just. budget visual/audio offset, where it shifts the notes and doesn't shift events at all. and right now funkin is overall really unclear to the players what each offset does i think (haven't checked the new update's offset menu yet)

might be worth bringing more attention at https://github.com/FunkinCrew/Funkin/issues/5396 in the future i think - brings discussion where i think it's needed i'd probably be interested in working on some better implementation if there's some consensus on how offsets should work

[Kade-github]

this pr I think doesn't really work for the new update because we have gotten rid of input/visual offsets for now, and we just have an audio offset. At least until dave changes the menus and what not.

Will keep it open and up to the contributor if they want to close it!

[xenkap]

Figured! Yeah, the system seems to be a lot better (and more straightforward) than what it was last time (finally, neat offset menu! :D) I'll close this PR for now - doesn't seem necessary to keep it up. Thanks :]

(staying interested in any potential future offset issues)

[xenkap]

https://github.com/user-attachments/assets/2bbf38af-a899-4426-8405-6d239b79908c

...hang on a sec, this doesn't seem right (todo: look into this) (ignore file name)

[xenkap]

~i didn't mean to reopen it oops but if i find something i'll open a new pr (unreasonable performance drop; sustains having unusual length?)~

EDIT: ...okay!

• Sustains were broken on my end because I compiled the game on this PR :sob: oops. everything's fine!!!!
• The lag issue is unrelated to this PR, but has to do with # 5177 (and it is REALLY bad)