Palimpsest icon indicating copy to clipboard operation
Palimpsest copied to clipboard

compare_results() not working. "`template` must have a `names` attribute."

Open subashani01 opened this issue 1 year ago • 5 comments

compare_tab <- compare_results(reference_sigs = SBS_cosmic, extraction_1 = SBS_denovo_sigs); compare_tab Error: Internal error: template must have a names attribute.

While running the compare_results(), it shows me this error. I have checked the attributes of both inputs and both have names attribute. Please help me resolving this.

I have tried with your test data as well and getting the same error.

subashani01 avatar Feb 17 '24 06:02 subashani01

Dear @subashani01, I have just run the test script with the test data on my personal computer (Palimpsest 2.0.0, R 4.1.3), and I have no error when running compare_tab <- compare_results(reference_sigs = SBS_cosmic, extraction_1 = SBS_denovo_sigs). Have you tried to run it again with a fresh R environment to avoid interactions with other loaded packages?

FunGeST avatar Feb 19 '24 11:02 FunGeST

Thank you so much for replying. Yes, I have. Also, I am using R 4.3.2

subashani01 avatar Feb 24 '24 10:02 subashani01

I am having the exact same error message. I am using Palimpsest_2.0.0, R 4.2.1.

nyoonhee avatar Mar 07 '24 23:03 nyoonhee

Can R version be the cause of error?

subashani01 avatar Mar 18 '24 07:03 subashani01

Dear all,

Firstly thank you for using Palimpsest!

I have just encountered this error for the first time, as @subashani01 suggests this seems to be an error that occurs with newer versions of R, although this was in no part helped by my dodgy old code!

I have fixed this error, although unfortunately I dont currently have access to the @FunGeST account so can't merge myself (if someone sees this please feel free to merge my pull request #57 !), but you can download the fixed code from my github:

devtools::install_github("benedict909/Palimpsest")

Let me know if you have any more issues 😄

Benedict

benedict909 avatar Apr 19 '24 14:04 benedict909

Thank you @benedict909, your pull request #57 has been merged!

FunGeST avatar May 23 '24 14:05 FunGeST

The fix provided by @benedict909 should resolve the issue, it has been merged to the main.

FunGeST avatar May 23 '24 14:05 FunGeST