sway icon indicating copy to clipboard operation
sway copied to clipboard

Rename U128.as_64 to try_as_u64 and deprecate the old function

Open SwayStar123 opened this issue 9 months ago • 10 comments

The function name is inconsistent with other downcasts, it needs to be updated to try_as_u64, and the old function needs to be deprecated and then later removed.

SwayStar123 avatar Feb 24 '25 12:02 SwayStar123

I would like to give this a go. Can I be assigned on this issue

anushkasomani avatar Feb 28 '25 13:02 anushkasomani

@SwayStar123 could you please provide the file directory in which i need to change. I'm unable to find it

anushkasomani avatar Feb 28 '25 14:02 anushkasomani

sway-lib-std/src/u128.sw

SwayStar123 avatar Feb 28 '25 14:02 SwayStar123

Hello, could I work on this?

FriendlyLifeguard avatar Mar 25 '25 08:03 FriendlyLifeguard

Hello, this serves my intentions to take on the task of renaming U128.as_64 to try_as_u64 and deprecating the old function. This change will align the function name with other downcasts, making our codebase more consistent and easier to understand.

I'll ensure that the deprecation process is handled smoothly, updating any internal usages and providing clear guidance for external users to transition to the new function.

bernardev254 avatar Mar 25 '25 08:03 bernardev254

Let me handle this issue!

pheobeayo avatar Mar 26 '25 10:03 pheobeayo

Following up on my work on #7042 and #7043, I'd like to continue fixing issues on Sway, please assign me.

saimeunt avatar Mar 27 '25 15:03 saimeunt

Could I take on this issue?

Zeegaths avatar Mar 27 '25 17:03 Zeegaths

Can I start working on this?

Sundayabel222 avatar Mar 28 '25 13:03 Sundayabel222

i will like to work on this. ETA 24 hours

Sendi0011 avatar Jun 05 '25 11:06 Sendi0011