smartparens icon indicating copy to clipboard operation
smartparens copied to clipboard

Feature/generic string

Open ThibautVerron opened this issue 5 years ago • 3 comments

Hi,

This is a pull request for the code related to the generic string delimiters ( #1039 ). You might want to squash the history, the last commits were very messy (sorry about that).

It turns out that this:

As it is, it might be slightly breaking for ruby users, for example sp-backward-sexp with %w(asd)| will now move the point to before %, not before the opening paren.

is no longer a problem.

But on the other hand, I don't know how to do it again if we were to decide that it is the wanted behaviour. Something seems to be overriding the detection of the string somewhere in sp-get-expression.

Emacs' default sexp navigation (using syntax tables) correctly navigates to the beginning of the string in the same scenario.

Thanks for your work ! :)

ThibautVerron avatar Oct 08 '20 14:10 ThibautVerron

You might want to squash the history, the last commits were very messy (sorry about that).

Or should I do it and offer to merge a clean branch?

ThibautVerron avatar Oct 08 '20 14:10 ThibautVerron

No problem with the squash, GitHub can do it automatically when merging. Thank you for the PR, I'll review it shortly.

Fuco1 avatar Oct 19 '20 20:10 Fuco1

Ping? :)

ThibautVerron avatar Oct 01 '21 08:10 ThibautVerron