frontend.mu icon indicating copy to clipboard operation
frontend.mu copied to clipboard

Github SSO

Open MrSunshyne opened this issue 1 year ago • 2 comments

MrSunshyne avatar Aug 16 '24 16:08 MrSunshyne

Deploying frontend-mu-nuxt with  Cloudflare Pages  Cloudflare Pages

Latest commit: b06ef97
Status: ✅  Deploy successful!
Preview URL: https://a0e02787.frontend-mu-staging.pages.dev
Branch Preview URL: https://163-github-login.frontend-mu-staging.pages.dev

View logs

TODO: Add error handling on failed GitHub sign in.

Reasons for failure:

  • Email address is not public (in GitHub settings)
  • Other reasons?

n-d-r-d-g avatar Sep 15 '24 17:09 n-d-r-d-g

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the authentication functionality within the Nuxt.js application. The useAuth utility has been updated to support multiple OAuth providers and improved user data handling. The LoggedUser, LoginForm, MyProfile, and RsvpAttendeeList components have received formatting adjustments for better readability and user interface improvements. Additionally, new alert dialog components have been introduced, and the mapToValidUser function along with relevant interfaces have been modified to include new properties for user identification.

Changes

File Path Change Summary
packages/frontendmu-nuxt/auth-utils/useAuth.ts Enhanced useAuth with oAuthLogin supporting multiple providers, updated getCurrentUser fields, modified loginWithSSO, and improved error handling in updateUserVerification.
packages/frontendmu-nuxt/components/auth/LoggedUser.vue Reformatted <template> for clarity, added provider-specific image handling, and standardized transition effects.
packages/frontendmu-nuxt/components/auth/LoginForm.vue Updated oAuthLogin function calls with parameters for 'google' and 'github', and improved input field formatting.
packages/frontendmu-nuxt/components/auth/MyProfile.vue Made formatting adjustments for improved readability without functional changes.
packages/frontendmu-nuxt/components/auth/RsvpAttendeeList.vue Updated logic for rendering profile pictures based on attendee's provider, with standardized class attributes.
packages/frontendmu-nuxt/utils/helpers.ts Modified mapToValidUser for better handling of names and added provider and external_identifier to returned user object.
packages/frontendmu-nuxt/utils/types.ts Updated User and Attendee interfaces to include new optional properties: provider and external_identifier.
packages/frontendmu-nuxt/components/auth/LoginWithGithub.vue Introduced new component for GitHub login, encapsulating the OAuth login logic and UI.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialog.vue Added new alert dialog component for user interactions, utilizing props and emits from the radix-vue library.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogAction.vue Introduced new component for action buttons within alert dialogs, supporting dynamic class bindings.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogCancel.vue Added component for cancel buttons in alert dialogs, with computed properties for class management.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogContent.vue New component for dialog content, managing props and emits effectively.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogDescription.vue Introduced component for dialog descriptions, supporting flexible content insertion.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogFooter.vue Added component for dialog footers, managing layout and styling through props.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogHeader.vue New component for dialog headers, allowing for customizable styling.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogTitle.vue Introduced title component for alert dialogs, supporting dynamic class bindings.
packages/frontendmu-nuxt/components/ui/alert-dialog/AlertDialogTrigger.vue Added trigger component for alert dialogs, facilitating flexible content management.
packages/frontendmu-nuxt/components/ui/alert-dialog/index.ts Exported all alert dialog components for easy import and usage throughout the application.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Auth
    participant Server
    User->>Auth: oAuthLogin(provider)
    Auth->>Server: Request login URL
    Server-->>Auth: Return login URL
    Auth->>User: Redirect to login URL
    User->>Auth: Login success
    Auth->>Server: Fetch current user data
    Server-->>Auth: Return user data (including provider, external_identifier)
    Auth->>User: Display user profile

🐇 "In the land of code where rabbits play,
New features hop in, brightening the day.
With OAuth support, we leap and bound,
User profiles richer, joy all around!
So let’s celebrate with a cheerful cheer,
For every change brings us closer, my dear!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 09 '24 18:10 coderabbitai[bot]