django-react-templatetags icon indicating copy to clipboard operation
django-react-templatetags copied to clipboard

Hypernova SSR not propagating errors correctly

Open rinti opened this issue 5 years ago • 1 comments

This problem might be with hypernova-python plugin. The error gets stuck inside "results" and not at the base dictionary. Eventhough I get the response that everything is OK, the SSR failed.

This is a snippet of the JSON returned from https://github.com/ornj/hypernova-python/blob/master/hypernova/init.py#L79

{
  "success": True,
  "error": "None",
  "results": {
    "Components.App": {
      "name": "Components.App",
      "html": "None",
      "meta": {

      },
      "duration": 310.156114,
      "statusCode": 500,
      "success": False,
      "error": {
        "name
        ":"
        ReferenceError ",
        "message": "window is not defined",
        "stack": [
          "ReferenceError: window is not defined",
          "at useMediaQuery (/mnt/persist/www/signalisten/shared/ssr/frontend/ssr_frontend/utils/useMediaQ
          uery.js: 37: 25)
        ",
        ]
}

rinti avatar Aug 15 '20 15:08 rinti

Thanks @rinti! Will investigate what the proper Hypernova result should look like and make sure hypernova-python follows that structure.

marteinn avatar Aug 16 '20 06:08 marteinn