FroshPlatformTemplateMail icon indicating copy to clipboard operation
FroshPlatformTemplateMail copied to clipboard

Fix convert error and use saleschannel name translation

Open MelvinAchterhuis opened this issue 1 year ago • 1 comments

  • Fix https://github.com/FriendsOfShopware/FroshPlatformTemplateMail/issues/70, use 'Administration' as fallback name when no salesChannelId is present in the dataBag
  • Use getTranslation('name') for retrieving salesChannel name

MelvinAchterhuis avatar Jul 29 '24 20:07 MelvinAchterhuis

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (269fd74) to head (3fde124). Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/Subscriber/FlowSubscriber.php 83.33% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
- Coverage     89.58%   83.62%   -5.96%     
- Complexity       78       89      +11     
============================================
  Files            10       12       +2     
  Lines           240      287      +47     
============================================
+ Hits            215      240      +25     
- Misses           25       47      +22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 29 '24 20:07 codecov-commenter

whoopsiee i merged https://github.com/FriendsOfShopware/FroshPlatformTemplateMail/pull/78 🙈 . I will close this then. Anyway thanks 🙈

shyim avatar Oct 29 '24 21:10 shyim