Extensions icon indicating copy to clipboard operation
Extensions copied to clipboard

Published 20 hours ago • verified publisher icon FreshRSS

xExtension-YouTube warnings in stream

Open pax0707 opened this issue 1 year ago • 7 comments

This happens when enabling "Display the feeds content" in extension options with latest extension and edge build. Wasn't happening with the build few days ago when I was testing.

Warning: DOMDocument::loadHTML(): Tag figure invalid in Entity, line: 2 in /var/www/FreshRSS/extensions/xExtension-YouTube/extension.php on line 203

Warning: DOMDocument::loadHTML(): Tag figcaption invalid in Entity, line: 2 in /var/www/FreshRSS/extensions/xExtension-YouTube/extension.php on line 203

image

pax0707 avatar Mar 17 '24 23:03 pax0707

+1

karmicdude avatar Nov 21 '24 19:11 karmicdude

Is it still a problem?

Alkarex avatar Jan 16 '25 20:01 Alkarex

@Alkarex yes @ 1.25.1-dev.

Image

pax0707 avatar Jan 16 '25 21:01 pax0707

Ping @kevinpapst or @ImAReplicant for a little help if you are around

Alkarex avatar Jan 16 '25 21:01 Alkarex

Yeah, I think Youtube change the embedded HTML and the PHP Doc Parser does not support HTML5 tags like figure.

That's what 8.4 brings in: https://www.php.net/releases/8.4/en.php#dom_additions_html5

Not sure what to do. Shall we add the @ shut up operator?

kevinpapst avatar Jan 16 '25 22:01 kevinpapst

That's what 8.4 brings in

That sounds like the solution for the image proxy as well. But what to do in the meantime. :)

Frenzie avatar Jan 16 '25 22:01 Frenzie

Related to https://github.com/FreshRSS/FreshRSS/issues/6831 I think the approach is to start using the new PHP 8.4+ functions and define a fallback compatible with PHP 8.1 (using the old functions and hiding the errors at least). I will try to draft something in the core. In the meantime, hiding the errors would be good

Alkarex avatar Jan 16 '25 22:01 Alkarex