AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

auto-generated avatar grid [bounty: 30 XTR]

Open DreadKnight opened this issue 1 year ago • 4 comments

If moving around a unit regarding realm and level, the avatar doesn't update automatically in the dash avatar grid. This is based on work done here -> #846 https://github.com/CyberBishop/AncientBeast/commit/32d79097c8ef331a30b159af1537b5f929fd2020#diff-7a4b8145c1bf2bf544d29967ab26fcd9f62cfe7944aa1c0a1b255c8cdd41e001R2555

The problem revolves around this file -> https://github.com/FreezingMoon/AncientBeast/blob/master/src/style/avatars.less

The file could be generated at build time right into deploy and have the file itself removed from repo if that makes sense or perhaps some CSS3 could be used in the process to display things properly.

Ideally would keep in mind set attribute as well, as we'll have support for multiple sets given time.

DreadKnight avatar Nov 11 '24 08:11 DreadKnight

hey @DreadKnight is this issue still open ? do you want me Instead of hardcoding those avatar rules, write a script that generates the .less file dynamically. (like the title of the issue : auto-generated avatar grid)

yousefsassy avatar Mar 22 '25 20:03 yousefsassy

hey @DreadKnight is this issue still open ? do you want me Instead of hardcoding those avatar rules, write a script that generates the .less file dynamically. (like the title of the issue : auto-generated avatar grid)

@yousefsassy Heya! Issue is still open. Note that someone poked at it in a PR, but it wasn't functioning properly and he never finished (stale), so feel free to get inspired by that if you want to 🐻

Will assign you to it, 2 weeks soft deadline.

DreadKnight avatar Mar 22 '25 20:03 DreadKnight

@yousefsassy Here's the PR in case you missed it: https://github.com/FreezingMoon/AncientBeast/pull/2656

Feel free to clone that and fix it 🐻

DreadKnight avatar Mar 22 '25 20:03 DreadKnight

@DreadKnight will see it, might as well create my proper branch for it and try to fix it ! like the usual, i will provide you a great description of what i did 🐺

yousefsassy avatar Mar 22 '25 20:03 yousefsassy