AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

some svgs problematic in Firefox [bounty: 4 XTR]

Open DreadKnight opened this issue 1 year ago • 6 comments

Firefox doesn't display svg icons that show up above units, such as the skip turn icon when there are no actions left to do. This caused for us to have a duplication of that icon, in png format, in order to temporarily bypass the issue.

DreadKnight avatar Aug 11 '24 02:08 DreadKnight

Hi, first time contributer here. Would love to work on this task. Is there any other issue linked to this issue available on GitHub right now??

abhayrsr avatar Aug 11 '24 07:08 abhayrsr

Hi, first time contributer here. Would love to work on this task. Is there any other issue linked to this issue available on GitHub right now??

Heya! Assigned you to it. 2 weeks soft deadline 🐻 Will poke you if stuff is linked to it.

DreadKnight avatar Aug 11 '24 09:08 DreadKnight

Hi @DreadKnight To better understand this one could you pls provide a video or screen recording that demonstrates the problem?

@Nazim9945 Heya! Please poke at some other issue that's not assigned and easier for you to understand; lots of them open.

DreadKnight avatar Aug 27 '24 12:08 DreadKnight

@abhayrsr Heya! Any progress with this one?

DreadKnight avatar Aug 27 '24 12:08 DreadKnight

I tried but not able to progress. you can assign it to others. Thanks!

abhayrsr avatar Aug 27 '24 14:08 abhayrsr

Hey. I would like to take a crack at this issue. May I be assigned this?

Changh341 avatar Sep 20 '24 10:09 Changh341

Hey. I would like to take a crack at this issue. May I be assigned this?

Heya! Sure thing, go for it.

DreadKnight avatar Sep 20 '24 13:09 DreadKnight

I was able to find the source of the bug and fix it. However I only know of skip button icon that appear above units. Are there any other SVG icons that appear on units that I should look at as the fix involves correcting the markup of the SVG.

Changh341 avatar Sep 21 '24 22:09 Changh341

I was able to find the source of the bug and fix it. However I only know of skip button icon that appear above units. Are there any other SVG icons that appear on units that I should look at as the fix involves correcting the markup of the SVG.

@Changh341 Good to hear! Only that icon for now and we switched to a png for it to avoid the bug. Wanted to add more icons like that, but didn't wanted to duplicate files too much.

DreadKnight avatar Sep 21 '24 22:09 DreadKnight