AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

problematic UI buttons [bounty: 5 XTR]

Open DreadKnight opened this issue 2 years ago • 4 comments

The score and fullscreen buttons started displaying weird when the game itself is small, like on phones.

Screenshot_20230117_022503_Samsung Internet

DreadKnight avatar Jan 17 '23 00:01 DreadKnight

So do you want to change the layout for UI buttons or some other fix??

RaSh-A avatar Mar 23 '23 02:03 RaSh-A

@RaSh-A When screen is small, right side stuff is a bit messy. The upper right button needs to be displayed in its spot, fully visible. Also the fullscreen button needs to be full size, not shrinked. So the interface would need maintain consistency, like when the game is big.

DreadKnight avatar Mar 23 '23 11:03 DreadKnight

Interface elements like those buttons are currently rendered in HTML. The play area is rendered using Phaser from what I've seen. Is there a reason for that? Could they all be rendered using Phaser?

andretchen0 avatar Mar 23 '23 16:03 andretchen0

It's easier to make UI that adjusts based on viewport and even sits beyond the game canvas if is, hence why it's somewhat common practice. We also had first prototype in DOM, then switched to canvas (vanilla, out own engine) then to Phaser when it was just released and lacked any documentation, so it was less to port to some semi-questionable game engine at the time that we weren't sure we would stick with.

On Thu, Mar 23, 2023, 6:04 PM andretchen0 @.***> wrote:

Interface elements like those buttons are currently rendered in HTML. The play area is rendered using Phaser from what I've seen. Is there a reason for that? Could they all be rendered using Phaser?

— Reply to this email directly, view it on GitHub https://github.com/FreezingMoon/AncientBeast/issues/2145#issuecomment-1481463318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPNX64U5AKW4BEANU5E3DW5RX7BANCNFSM6AAAAAAT5IKRRM . You are receiving this because you authored the thread.Message ID: @.***>

DreadKnight avatar Mar 23 '23 16:03 DreadKnight

@DreadKnight Hi there ! Can I get assign this to me ?

I made a PR https://github.com/FreezingMoon/AncientBeast/pull/2608

nohaibogdan1 avatar Aug 22 '24 09:08 nohaibogdan1

@DreadKnight Hi there ! Can I get assign this to me ?

I made a PR #2608

@nohaibogdan1 Hello fellow romanian! I've assigned you to it; gonna check out the PR in a bit and test it out 🐻

DreadKnight avatar Aug 22 '24 12:08 DreadKnight