AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

Mud Bath creation sound

Open DreadKnight opened this issue 5 years ago • 7 comments

Creating a Mud Bath should have a fitting sound, perhaps the first one from here https://opengameart.org/content/sounds-fxs

DreadKnight avatar Jun 29 '20 13:06 DreadKnight

Duplicate of #889

DreadKnight avatar Jun 29 '20 13:06 DreadKnight

Is this up for grabs? I could add in the sound real quick!

AT1452 avatar Jul 21 '20 05:07 AT1452

@AT1452 Sure thing, go ahead! There are quite a few issues like this as we've made quite a bit of SFX, but didn't knew how to implement them myself and nobody else did so far.

DreadKnight avatar Jul 21 '20 09:07 DreadKnight

Can I contribute to this?

rachel-l-sanchez avatar Aug 21 '22 23:08 rachel-l-sanchez

@rachel-l-sanchez Sure thing, but hopefully you can code it into the game as well, since that's usually the bottleneck of the project, coding.

DreadKnight avatar Aug 21 '22 23:08 DreadKnight

I can do that.

rachel-l-sanchez avatar Aug 22 '22 00:08 rachel-l-sanchez

@rachel-l-sanchez Neat :3 I'll assign you, deadline 2 weeks. Feel free to drop by our discord and don't forget to ⭐ the project.

DreadKnight avatar Aug 22 '22 00:08 DreadKnight

@DreadKnight I figured how to get the sound files in. Is the expectation from a gameplay perspective that adding the play sound line in Swine-Thug.js after createTrap solve for this issue?

hex.createTrap('mud-bath', effects, ability.creature.player); game.soundsys.playSound(game.soundLoaded[7], game.soundsys.effectsGainNode);

viveknshah avatar Oct 24 '22 19:10 viveknshah

@DreadKnight I figured how to get the sound files in. Is the expectation from a gameplay perspective that adding the play sound line in Swine-Thug.js after createTrap solve for this issue?

hex.createTrap('mud-bath', effects, ability.creature.player); game.soundsys.playSound(game.soundLoaded[7], game.soundsys.effectsGainNode);

Yeah, I guess so. Feel free to open a PR :-)

DreadKnight avatar Oct 24 '22 19:10 DreadKnight