wordpress-sdk icon indicating copy to clipboard operation
wordpress-sdk copied to clipboard

Plugin Check (PCP) Compatibility

Open flowdee opened this issue 1 year ago • 1 comments

Running tests via the new Plugin Check (PCP) over our plugins throws tons of complaints related to the Freemius WP SDK.

It would be great to get this optimized and sorted out from time to time, before they probably make passing the plugin check a requirement.

Besides that, doesn't hurt to optimize things anyway I guess 😎

flowdee avatar Sep 23 '24 07:09 flowdee

Hey @flowdee 👋

Thanks for bringing this up!

I wanted to clarify that the only category relevant for plugin review submission is the "Plugin Repo" category: image

When that category is selected, the Plugin Check (PCP) doesn’t flag any errors related to the Freemius SDK—aside from the updater, which we've already addressed in collaboration with the review team.

We’ve also tested other categories and noticed that PCP relies on stateless static code analysis, which generates tons of false positives. We understand that seeing these alerts can be frustrating, but rest assured, they don’t reflect actual issues with the SDK.

That being said, we’re always keen on improving, and your feedback is appreciated. We’ll continue keeping an eye on this and optimizing where necessary to ensure compliance as we go.

vovafeldman avatar Sep 23 '24 07:09 vovafeldman

@vovafeldman Hi! But with freemius sdk I can't upload a plugin to wordpress org repo. So it makes everything complicated... image

davidkobielski avatar Oct 23 '24 18:10 davidkobielski

Thanks for flagging this, @davidkobielski! We're aware of the issue where the updater class is being flagged as an error, even though we've cleared it with the WordPress.org plugin review team (FYI it's turned off for free products). Interestingly, this only seems to happen when the SDK isn’t included with Composer, so we're actively working on ensuring a smooth experience with Composer-based integrations. We’ll be updating the SDK integration instructions soon to reflect these improvements.

vovafeldman avatar Oct 27 '24 08:10 vovafeldman

Hi @vovafeldman, Facing the same issue, I've got response: https://cln.sh/5gSjJh2N What should I do now?

litonarefin avatar Apr 20 '25 06:04 litonarefin

Hello @litonarefin and @davidkobielski We have already updated our integration instruction both for composer as well as non composer methods. The changes and explanation can be found here.

Basically,

  1. If using composer: Everything works smoothly without any issues.
  2. Otherwise you can manually create a vendor directory and put our SDK inside that.

If you follow the integration instruction from the Developer Dashboard you will find the same:

Image

I hope this helps. I am closing this ticket now. If you have more doubts or issues, please feel free to contact us through our support.

swashata avatar May 01 '25 08:05 swashata

This needs to be addressed in the future, so that Freemius SDK passes plugin check.

More info : https://make.wordpress.org/plugins/2025/10/29/plugin-check-plugin-now-creates-automatic-security-reports-update/

bradvin avatar Nov 04 '25 14:11 bradvin