FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Add null-check for RichShelf playlist url

Open ChunkyProgrammer opened this issue 9 months ago • 7 comments

Add null-check for RichShelf playlist url

Pull Request Type

  • [x] Bugfix

Description

This is causing error on the music channel since it is missing the url property.

Testing

  • can't test right now since music channel is currently empty due to a bug (addressed here: https://github.com/LuanRT/YouTube.js/pull/891 )

Desktop

  • OS: Fedora Linux
  • OS Version: 41
  • FreeTube version: latest nightly

ChunkyProgrammer avatar Feb 20 '25 23:02 ChunkyProgrammer

Mark as draft since we can't test yet?

PikachuEXE avatar Feb 22 '25 02:02 PikachuEXE

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 11 '25 02:03 github-actions[bot]

I set this PR as ready for review since url is defined as nullable in YouTube.js (even without the changes from my YouTube.js PR) so this should be merged even if we can't find any issues at this moment

ChunkyProgrammer avatar Apr 24 '25 02:04 ChunkyProgrammer

What specific screen(s) can be viewed to run the changed code? I would like to just run the code once

PikachuEXE avatar Apr 25 '25 08:04 PikachuEXE

I would like to test this PR. Could you provide a test channel.

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar May 21 '25 02:05 github-actions[bot]

I would like to test this PR. Could you provide a test channel.

@ChunkyProgrammer

AFAIK the YouTube music channel is the only channel that needs this. I'll close this PR for now and will reopen it if necessary

ChunkyProgrammer avatar Jun 26 '25 01:06 ChunkyProgrammer