FreeTube
FreeTube copied to clipboard
Add local api support for viewing individual community posts + comments
Add local api support for viewing community posts
Pull Request Type
- [x] Feature Implementation
Related issue
closes #3253
Description
This PR also adds support for viewing community posts + comments to the local API
Testing
- set local api as primary api
- disable invidious
- go to mr beast channel
- go to community tab
- click on the link to view one of the posts
- load comments
- load comment replies
- load more comments
See tests here: https://github.com/FreeTubeApp/FreeTube/pull/5589
Desktop
- OS: Fedora Linux
- OS Version: 41
- FreeTube version: latest nightly
Upstream just merged🎉
Error:
https://github.com/user-attachments/assets/e41deb9d-eae9-48e1-aa58-b990664dcdb5
Error: VirtualBoxVM_2gUbmdP7GZ.mp4
Hmm, weirdly I'm only getting that error on that specific post
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
Opening a post link without a channel ID fails, this isn't caused by this PR as it is broken on both backends and the resolve URL response for post URLs seems to have changed on YouTube's end e.g. https://www.youtube.com/post/UgkxtZU_keFi3mw46hCUe9YfhfBHoeR8YCoM
Here is the Innertube /navigation/resolve_url response for that URL, params is a weird protobuf that has two field with the channel ID and one field with the post ID.
{
"responseContext": {},
"endpoint": {
"clickTrackingParams": "",
"commandMetadata": {
"webCommandMetadata": {
"url": "/channel/UCBR8-60-B28hp2BmDPdntcQ/community?lb=UgkxtZU_keFi3mw46hCUe9YfhfBHoeR8YCoM",
"webPageType": "WEB_PAGE_TYPE_BROWSE",
"rootVe": 247244,
"apiUrl": "/youtubei/v1/browse"
}
},
"browseEndpoint": {
"browseId": "FEpost_detail",
"params": "wgNaEhhVQ0JSOC02MC1CMjhocDJCbURQZG50Y1EaJFVna3h0WlVfa2VGaTNtdzQ2aENVZTlZZmhmQkhvZVI4WUNvTVoYVUNCUjgtNjAtQjI4aHAyQm1EUGRudGNR"
}
}
}
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
Only thing that is left to be done is a rebase into dev branch to test out if the errors are really gone right?
Pretty sure nothing was done to address this comment yet: https://github.com/FreeTubeApp/FreeTube/pull/6491#issuecomment-2686444748
So rebasing would only get rid of the code conflicts but not resolve that comment.
Images look strange but might not be related to PR
Comments can't be loaded
Images look strange but might not be related to PR
@PikachuEXE see #4852
Can confirm that the post link issue is fixed. As was already mentioned by pika, on some posts the comments don't load at all and for others they fail when sorting. For the sorting issue taking the same approach that we do for sorting the video comments should work (using the sort payloads provided by YouTube instead of making YouTube.js generate it).
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
PR opened on YouTube.js: https://github.com/LuanRT/YouTube.js/pull/955
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
Conflicts have been resolved. A maintainer will review the pull request shortly.
Waiting for https://github.com/LuanRT/YouTube.js/pull/956 to be release
https://github.com/FreeTubeApp/FreeTube/pull/7542
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Relies on: https://github.com/LuanRT/YouTube.js/pull/987 and https://github.com/LuanRT/YouTube.js/pull/986