FreeTube
FreeTube copied to clipboard
FreeTubeApp
Add support for upcoming livestream trailers
Add support for upcoming livestream trailers
Pull Request Type
- [x] Feature Implementation
Related issue
https://github.com/LuanRT/YouTube.js/pull/842
Description
This will be difficult to test but some upcoming videos have trailers to view before the stream is uploaded. For example, this is an upcoming video that has a trailer: https://youtu.be/t28qkILDe58 (it will most likely be uploaded by the time this PR gets reviewed).
Screenshots
Upcoming video with trailer:
Upcoming video without trailer:
Other video (movie) with trailer:
Testing
- kinda difficult, find an upcoming live stream that has a trailer associated with it and go to the watch page
- find an upcoming live stream that doesn't have a trailer associated with it and go to the watch page
- find a movie that has a trailer associated with it and go to the watch page
Desktop
- OS: Fedore Linux
- OS Version: 41 KDE
- FreeTube version: 0.22.x (latest nightly)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
Having trouble finding other upcoming videos with trailers so I'll leave this as a draft for now (also it looks like the trailer was removed from the test video?)
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.
Wait a sec...upstream merged and released a while ago. Any reason for this to be in draft?
Wait a sec...upstream merged and released a while ago. Any reason for this to be in draft?
I haven't found another video to test with so I left it in draft
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
haven't found any other videos like this and the video I found that had this no longer has a trailer it seems.
@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE Reviving this as we have a new an upcoming video with a trailer so we can test this. Please review at your earliest convenience (the video in question will premiere in about 16 hours).
https://youtu.be/ari1XFUw73w
