FreeTube
FreeTube copied to clipboard
Don't make requests when importing subscriptions
Don't make requests when importing subscriptions
Pull Request Type
- [x] Bugfix
Related issue
- Avoids rate limit when importing subscriptions
- closes https://github.com/FreeTubeApp/FreeTube/issues/3943
- closes https://github.com/FreeTubeApp/FreeTube/issues/5594 (last comment mentions the errors that this pull request fixes)
- closes https://github.com/FreeTubeApp/FreeTube/issues/4388
Description
A simplified version of https://github.com/FreeTubeApp/FreeTube/pull/4340 that doesnt worry about having a lot of logic for fetching thumbnails if it's missing, the thumbnails can be fetched from other places (visiting the channel, refreshing subscriptions with local api + no rss)
Screenshots
Testing
See: https://github.com/FreeTubeApp/FreeTube/issues/3735#issuecomment-1642286050 & https://github.com/FreeTubeApp/FreeTube/pull/4340
- profiles.txt
- subscriptions.csv
- SubscriptionsError.csv
- SubscriptionsNoError.csv
- Test.Subscriptions.txt
- freetube-subscriptions.json
Change file extension .txt to .db
(Notice how much faster importing subscriptions is)
Desktop
- OS: Linux Mint
- OS Version: 22
- FreeTube version: latest nightly
Hi error~
Oops more errors
@PikachuEXE found the issue, interestingly, this error could happen when not using this PR
Duplicate keys detected: 'UC59AcfHD5jOGqTxb-zAsahw'. This may cause an update error.
@PikachuEXE you're somehow subscribed to the same channel multiple times, not sure how that happened
I think the double subscribe issue should be fixed here: https://github.com/FreeTubeApp/FreeTube/pull/5617/commits/60a11d39290d9280f58a7636ec3eeb692142eb38 (you'll need to unsubscribe from the duplicate manually)