FreeTube
FreeTube copied to clipboard
Add dearrow support for thumbnails
Add dearrow support for thumbnails
Pull Request Type
- [x] Feature Implementation
Related issue
closes https://github.com/FreeTubeApp/FreeTube/issues/4146
Description
This PR allows for using DeArrow for thumbnails. This PR also stores the duration of a video in the dearrow cache if available and will fallback to the dearrow duration for shorts, etc.
Screenshots
DeArrowed Screenshot:
Non DeArrowed Screenshot:
Testing
test 1
- enable DeArrow Thumbnails
- enable DeArrow Titles
- go to subscription feed
- see DeArrowed titles when available
- See dearrowed thumbnails when available
test 2
- enable DeArrow Thumbnails
- disable DeArrow Titles
- go to subscription feed
- see some thumbnails update (if available). Thumbnails should update next time the page is viewed
test 3
- disable DeArrow Thumbnails
- enable DeArrow Titles
- see dearrowed titles when available
- see original thumbnail
Desktop
- OS: Solus
- OS Version: Solus 4.5 Resilience
- FreeTube version: 0.19.1
Is missing the tooltip label, otherwise is looking good behavior-wise.
All Thumbnail Preferences are overwritten except for Blur.
Q: Should we even overwrite thumbnail preference Hidden and Blur
-
If answer is yes then we should make this clear in the tooltip messaging
-
Im leaning towards no because when
Display Titles Without Excessive Capitalizationis enabled and DeArrow Titles are enabled, It will adjust the DeArrow titles to not use Excessive Capitalization. So if we continue this thoughtHiddenandBlurshould overwrite DeArrow Thumbnails