FreeTube
FreeTube copied to clipboard
FreeTubeApp
Vue3 Migration
Vue3 Migration
Pull Request Type
- [x] Other - migrate to vue3
Description
This PR migrates FreeTube to Vue3. From what I can tell, this mostly works but I'd like to do some more investigation and testing (hence the draft PR). I might close this PR if I don't have enough time to fix it but the existing code should be useful for anyone who wishes to take a stab at the vue 3 migration
upgrade vue to 3.3.10 upgrade vue-i18n to 9.8.0 upgrade vue-observe-visibility to 2.0.0-alpha.1 upgrade vue-router to 4.2.5 upgrade vuex to 4.1.0
Screenshots
Testing
- daily drive, if an error occurs that you cant reproduce in the development branch then report it
Desktop
- OS: Windows
- OS Version: 10
- FreeTube version: 0.19.1
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
The build warnings can be fixed by removing the set and del imports and replacing them with direct object modification, as Vue 3 can properly detect property changes.
set(x, y, z) can be replaced by x[y] = z
del(x, y) can be replaced by delete x[y]
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This PR is mostly complete as there may be some small bugs but code review is welcome (just no approving reviews yet!)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.