FreeTube
FreeTube copied to clipboard
FreeTubeApp
Add support for viewing movie trailers with local api
Add support for viewing movie trailers with local api
Pull Request Type
- [x] Feature Implementation
Related issue
Going to a video uploaded by YouTube Movies & TV would cause an error and nothing would be displayed.
Description
This PR will play the preview for movies.
Testing
(While using a canada vpn)
- Go to https://www.youtube.com/watch?v=BfgE0HczUco (with local api)
- search
Scott Pilgrim vs the World movie, click on the video byYouTube Movies & TV
Desktop
- OS: Windows
- OS Version: 10
- FreeTube version: 0.19.1
Sometimes it does load the trailer but sometimes i have the feeling that it is really trying to fetch to full movie, resulting in this error dump
What video did you get this error with?
Tested with the URL you provided in the PR body
@efb4f5ff-1298-471a-8973-3d47447115dc are you using a vpn or a proxy? I was able to reproduce with a vpn (the movie wasn't available in the region my vpn was in)
@ChunkyProgrammer Sounds like you need to also check the playability status of the trailer, the current code just assumes it always playable.
Yes i was using a VPN but like i said when it was playable it on that server it also sometimes threw the error at me
question: To confirm, is this what we want to happen when there is an error displaying the content, due to VPN issues or something like that?
question: To confirm, is this what we want to happen when there is an error displaying the content, due to VPN issues or something like that?
yup had the same issue on non Canadian server https://github.com/FreeTubeApp/FreeTube/pull/4391#pullrequestreview-1749445893
@efb4f5ff-1298-471a-8973-3d47447115dc But is that the same as what happened before with unplayable videos or is that collection of errors a result of this pull request?
@absidue
- UNPLAYABLE error i also got before this PR
- Vue warn error in mounted hook is new in this PR
- typeError bitrate error i also got before this PR
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
Might be best to always show the trailer if one exists, not just if there is an error, because free with ads movies exist and because they have DRM we can't show them either (Electron doesn't have Widevine out of the box, because it's closed source).
The appearance and functionality of the movie items in search results (they had a broken channel link before, now it just shows the text. additionally the description will show up for them in the list layout).
Got this error with Japan VPN searching Scott Pilgrim vs the World movie