Feature: A new way to subscribe

[minhhang107]

trafficstars

---

New way to subscribe

Pull Request Type Please select what type of pull request this is:

• [ ] Bugfix
• [x] Feature Implementation

Related issue Closes #1615 Closes #568

Description Added ft-subscribe-button component

• The component includes the existing Subscribe button and a plus button
• The plus button allows users to to select the profile they want to add the subscription to
• Replace the existing Subscribe button with the new component in video page and channel page
• If users try to add subscription to the same profile twice, show a toast message

Screenshots (if appropriate) Before:

After:

Testing (for code that is not small enough to be easily understandable) Has this pull request been tested? Yes

Please describe shortly how you tested it and whether there are any ramifications remaining: Tested locally on dev by adding/removing channels to/from different profiles using the existing Subscribe button and the new button, tested on both video page and channel page

Desktop (please complete the following information):

• OS: Windows
• OS Version: 10
• FreeTube version: 0.15.1

[efb4f5ff-1298-471a-8973-3d47447115dc]

@PrestonN idea time!

Maybe we can also do something like this when the playlist is implemented. So u can save a video in playlist in profile x while being in profile y

[minhhang107]

@efb4f5ff-1298-471a-8973-3d47447115dc The same thing can be done with playlist. Users can also add a video to multiple playlists in another profile. So what do you think about this PR? Are there anything that need to be fixed?

[efb4f5ff-1298-471a-8973-3d47447115dc]

I didn't had time to test in depth but initial thoughts about it that it is pretty well implemented

Would like to see #1833 mergerd before this one

[efb4f5ff-1298-471a-8973-3d47447115dc]

I didn't had time to test in depth but initial thoughts about it that it is pretty well implemented

Would like to see #1833 merged before this one

#1833 has been merged. Please address the changes that have been requested and resolve the merge conflicts in order for us to review.

[ChunkyProgrammer]

Things to fix: Channel grid takes up 5 or 4

Not sure: Dropdown obscures other elements: I think the dropdown is supposed to obscure the other elements?

Not to fix: "Unsubscribe functionality doesn't match original functionality": this is actually the intended functionality. There is an error with the code in the dev branch that prevents this from happening (it should be activeProfile._id instead of activeProfile) https://github.com/FreeTubeApp/FreeTube/blob/a5585afa18314cd4757b4a63a47c21cb3a9afc02/src/renderer/views/Channel/Channel.js#L563

[ChunkyProgrammer]

@efb4f5ff-1298-471a-8973-3d47447115dc could you test the grid thing again? (i didn't reproduce it)

[efb4f5ff-1298-471a-8973-3d47447115dc]

@efb4f5ff-1298-471a-8973-3d47447115dc could you test the grid thing again? (i didn't reproduce it)

@ChunkyProgrammer I have a big brain fart. Which video/picture we talking about?

[ChunkyProgrammer]

@efb4f5ff-1298-471a-8973-3d47447115dc could you test the grid thing again? (i didn't reproduce it)

@ChunkyProgrammer I have a big brain fart. Which video/picture we talking about?

This one

https://user-images.githubusercontent.com/73130443/170069153-ebb2da94-53dc-4e0c-b1cc-b06b57059326.mp4

[efb4f5ff-1298-471a-8973-3d47447115dc]

Just tested and i still get it :(

[efb4f5ff-1298-471a-8973-3d47447115dc]

channel.with.same.name.cant.add.channel.mp4

Fixed

Channelspace.moves.from.5.to.4.mp4

Fixed

dropdown.closes.everytime.u.add.channel.mp4

Fixed

dropdown.obscures.other.elements.mp4

Not sure if we should fix this. More discussion needed.

unsubscribe.functionality.doesnt.match.the.original.functionality.mp4

unrelated to this PR

wrong.icon.mp4

fixed

Fixed

Fixed

This isnt fixed and didnt explain it well. It is a minor visual issue but maybe this worth looking into.

https://user-images.githubusercontent.com/73130443/171063698-516329ae-c0fb-4f58-893e-6d23558feeca.mp4

[efb4f5ff-1298-471a-8973-3d47447115dc]

@ChunkyProgrammer do you think that this closes https://github.com/FreeTubeApp/FreeTube/issues/2213?

[ChunkyProgrammer]

@ChunkyProgrammer do you think that this closes #2213?

This PR doesn't really match their use case

[ChunkyProgrammer]

channel.with.same.name.cant.add.channel.mp4

Fixed

Channelspace.moves.from.5.to.4.mp4

Fixed

dropdown.closes.everytime.u.add.channel.mp4

Fixed

dropdown.obscures.other.elements.mp4

Not sure if we should fix this. More discussion needed.

unsubscribe.functionality.doesnt.match.the.original.functionality.mp4

unrelated to this PR

wrong.icon.mp4

fixed

Fixed

Fixed

This isnt fixed and didnt explain it well. It is a minor visual issue but maybe this worth looking into.

VirtualBoxVM_zHC57aBAEx.mp4

I think I may have fixed the issue you were having?

[PikachuEXE]

We do need some document to describe this new feature Also the tooltips need to be shown faster

Details

I see empty box if I have no other profiles... (and already subscribed) I know there is tooltip but they show a few seconds later and I don't think many people would notice it (It's still fine as is given it's explained well)

Same for profile full name tooltips

[efb4f5ff-1298-471a-8973-3d47447115dc]

I see empty box if I have no other profiles... (and already subscribed)

After looking at this again i do agree it is a bit weird when u see this for the first time. Maybe we can put a text in the middle of the box.

For when u click on the + button 'All profiles are subscribed to this channel. If u want to remove this channel from a profile click on - button' and the opposite text for when u click on the - button.

We could also disable the button when there is nothing more to add and show a toast message. Only giving this option because the first option i gave could be problematic with CSS on smaller screens

[PikachuEXE]

I am not sure if this only requires a better documentation to explain it (plus the improvements of course) Or also an option to only show these buttons when the new option is enabled (kind of advanced feature, with link to documentation)

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[PikachuEXE]

My points still stand

[ChunkyProgrammer]

My points still stand

I only resolved merge conflicts, didn't do any fixing

[PikachuEXE]

@ChunkyProgrammer I know ar~ Only for the record (I got goldfish memory)

Update

Misty's Psyduck:

[efb4f5ff-1298-471a-8973-3d47447115dc]

Only for the record (I got goldfish memory)

A @PikachuEXE that behaves like Misty's Psyduck

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions[bot]]

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[toby63]

One question: will or is this also possible in the playlist menu? Right now I have a large number of videos saved in the playlist on profile x and I would like to be able to transfer some of the videos to other profiles, without clicking on them first.

Also a way to choose multiple videos and "copy" them to another profile would be nice.