FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

Resolution qualities appear twice in quality selector

Open maplepy opened this issue 4 years ago • 39 comments

Behavior of the program Double resolution selection, when picking one of the two, the page will crash

Expected behavior One resolution to pick from, no crash

To Reproduce Please add all steps to reproduce the behavior:

  1. Go to a video
  2. Click on the resolution
  3. Click on one of the double resolution
  4. Crash
  5. Ctrl + R to reload to fix the page

Screenshot https://imgur.com/a/P01qxzF

Environment Information (please complete the following information):

  • OS: Manjaro
  • OS Version: [e.g. Windows 10, Ubuntu 20.04]
  • FreeTube version: v0.13.0 Beta
  • Installation Method (If applicable): Pacman
  • Primary API Used: Local

Additional context If you pick one of the two resolution, you can either get the resolution you picked or have the page crash, it's kind of a Russian roulette but not really funny and the only thing dying is my will to use Freetube

maplepy avatar May 26 '21 23:05 maplepy

GitHub allows uploading images directly Feel free to use it next time~ image

PikachuEXE avatar May 27 '21 08:05 PikachuEXE

Sorry, but atm I am unable to reproduce that on Windws. I can even go and click one after the other and it does not crash. Could you provide the logs in the console (You can open it with Ctrl + Shift + I I as in i). And please open the console beforehand and clear it before trying to set the resolution as there is a lot of standard output and warnings which can be ignored

GilgusMaximus avatar May 27 '21 17:05 GilgusMaximus

GitHub allows uploading images directly Feel free to use it next time~ image

I know and I wanted to but I kept on having an error, hence the link

maplepy avatar May 28 '21 02:05 maplepy

image Cleared the console before changing resolution, first two worked, the last one crashed the app

image Cleared the console right before clicking the video, tried the two same resolution, first one worked, second one crashed the app

mounted @ renderer.js:2
He @ renderer.js:2
Kt @ renderer.js:2
insert @ renderer.js:2
k @ renderer.js:2
js.nodeOps @ renderer.js:2
e._update @ renderer.js:2
n @ renderer.js:2
ci.get @ renderer.js:2
ci.run @ renderer.js:2
ai @ renderer.js:2
(anonymous) @ renderer.js:2
Qe @ renderer.js:2
Promise.then (async)
qe @ renderer.js:2
Xe @ renderer.js:2
(anonymous) @ renderer.js:2
ci.update @ renderer.js:2
e.$forceUpdate @ renderer.js:2
(anonymous) @ renderer.js:2
l @ renderer.js:2
He @ renderer.js:2
i @ renderer.js:2
(anonymous) @ renderer.js:2
(anonymous) @ renderer.js:2
c @ renderer.js:2
(anonymous) @ renderer.js:2
setTimeout (async)
$s @ renderer.js:2
(anonymous) @ renderer.js:2
requestAnimationFrame (async)
(anonymous) @ renderer.js:2
requestAnimationFrame (async)
Ps @ renderer.js:2
P @ renderer.js:2
As @ renderer.js:2
remove @ renderer.js:2
S @ renderer.js:2
_ @ renderer.js:2
js.nodeOps @ renderer.js:2
e._update @ renderer.js:2
n @ renderer.js:2
ci.get @ renderer.js:2
ci.run @ renderer.js:2
ai @ renderer.js:2
(anonymous) @ renderer.js:2
Qe @ renderer.js:2
Promise.then (async)
qe @ renderer.js:2
Xe @ renderer.js:2
(anonymous) @ renderer.js:2
ci.update @ renderer.js:2
ce.notify @ renderer.js:2
set @ renderer.js:2
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2991
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2990
updateRoute @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2411
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2265
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2399
step @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2003
step @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2010
runQueue @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2014
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2394
step @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2003
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2007
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2381
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2164
iterator @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2359
step @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2006
step @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2010
step @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2010
runQueue @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2014
confirmTransition @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2389
transitionTo @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2262
push @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:2706
push @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:3025
handler @ /usr/lib/freetube/app.asar/node_modules/vue-router/dist/vue-router.common.js:1141
He @ renderer.js:2
i @ renderer.js:2
Wn.o._wrapper @ renderer.js:2
Show 32 more frames
renderer.js:2 Getting video info please wait...
renderer.js:2 {page: "watch", player_response: {…}, response: {…}, html5player: "/s/player/e467278e/player_ias.vflset/en_US/base.js", formats: Array(27), …}
renderer.js:2 {page: "watch", player_response: {…}, response: {…}, html5player: "/s/player/e467278e/player_ias.vflset/en_US/base.js", formats: Array(27), …}
renderer.js:2 (26) [{…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, __ob__: Pe]
renderer.js:2 0
renderer.js:2 {isTrusted: true, screenX: 873, screenY: 483, clientX: 873, clientY: 417, …}
renderer.js:2 {isTrusted: true, screenX: 871, screenY: 453, clientX: 871, clientY: 387, …}```

maplepy avatar May 28 '21 02:05 maplepy

Cleared the console (verbose mode enabled), choose 144p resolution and app crashed image

61XHR finished loading: GET "<URL>".
renderer.js:2 {isTrusted: true, screenX: 872, screenY: 536, clientX: 872, clientY: 470, …}
/usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:255 XHR failed loading: GET "https://r1---sn-n4g-jqbek.googlevideo.com/videoplayback?expire=1622190277&ei=ZVSwYMDRLcXN0wW-r6XYCA&ip=81.67.182.221&id=o-APy32QPN_YFl3w57KQKjHHk5IiysPGUkcJnPfEkZqdRj&itag=394&aitags=133%2C134%2C135%2C136%2C137%2C160%2C242%2C243%2C244%2C247%2C248%2C271%2C278%2C313%2C394%2C395%2C396%2C397%2C398%2C399%2C400%2C401&source=youtube&requiressl=yes&vprv=1&mime=video%2Fmp4&ns=ud8VfIyzGFucXxKbh7caRaQF&gir=yes&clen=1366902&dur=179.833&lmt=1622150236950535&keepalive=yes&fexp=24001373,24007246&c=WEB&txp=5531432&n=QHFOO-_AKpHu5nHxSp&sparams=expire%2Cei%2Cip%2Cid%2Caitags%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&ratebypass=yes&sig=AOq0QJ8wRgIhAIeNMZRr-FitCQXWlMvYKwV6m9A2oDrYrYUxHwQyFTtfAiEA4049jzVSRSh8tGan_k2wBqWlPa-bs2LRuy6XOj0fFog%3D&redirect_counter=1&cm2rm=sn-n4g-nmc67e&req_id=a6e90df81b28a3ee&cms_redirect=yes&ipbypass=yes&mh=1c&mm=29&mn=sn-n4g-jqbek&ms=rdu&mt=1622168447&mv=m&mvi=4&pcm2cms=yes&pl=23&lsparams=ipbypass,mh,mm,mn,ms,mv,mvi,pcm2cms,pl&lsig=AG3C_xAwRQIhAK-NnlrzDwHgbqoovLcuocik_wtTj6ArNRQW6E_1JjtmAiB9s8OI8VF0YwqCYW6rA53PFIkrgTA97IIBWf9ujaXiFw%3D%3D&ir=1&rr=12".
_createXHR @ /usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:255
createXHR @ /usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:83
XhrFunction @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:30090
containerRequest @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:30739
addSidxSegments_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:31099
media @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:31222
switchMedia_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:49023
fastQualityChange_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:49624
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:50690
set @ /usr/lib/freetube/app.asar/node_modules/videojs-contrib-quality-levels/dist/videojs-contrib-quality-levels.cjs.js:84
(anonymous) @ renderer.js:2
setDashQualityLevel @ renderer.js:2
handleClick @ renderer.js:2
ClickableComponent._this.handleClick_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:10366
data.dispatcher @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:2211
/usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:255 XHR failed loading: GET "https://r1---sn-n4g-jqbek.googlevideo.com/videoplayback?expire=1622190277&ei=ZVSwYMDRLcXN0wW-r6XYCA&ip=81.67.182.221&id=o-APy32QPN_YFl3w57KQKjHHk5IiysPGUkcJnPfEkZqdRj&itag=137&aitags=133%2C134%2C135%2C136%2C137%2C160%2C242%2C243%2C244%2C247%2C248%2C271%2C278%2C313%2C394%2C395%2C396%2C397%2C398%2C399%2C400%2C401&source=youtube&requiressl=yes&vprv=1&mime=video%2Fmp4&ns=ud8VfIyzGFucXxKbh7caRaQF&gir=yes&clen=32663485&dur=179.833&lmt=1622136469488017&keepalive=yes&fexp=24001373,24007246&c=WEB&txp=5532434&n=QHFOO-_AKpHu5nHxSp&sparams=expire%2Cei%2Cip%2Cid%2Caitags%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&ratebypass=yes&sig=AOq0QJ8wRgIhAI_24OhVpeKWj2cwrB615GmWIBySzk-uwAYeSzHPJlRFAiEAyq0_8j0tzyFoc20_VFQdnbtQXZYdE-7Jifb8WPJfhLg%3D&redirect_counter=1&cm2rm=sn-n4g-nmc67e&req_id=ced98dc16c7ba3ee&cms_redirect=yes&ipbypass=yes&mh=1c&mm=29&mn=sn-n4g-jqbek&ms=rdu&mt=1622168447&mv=m&mvi=4&pcm2cms=yes&pl=23&lsparams=ipbypass,mh,mm,mn,ms,mv,mvi,pcm2cms,pl&lsig=AG3C_xAwRAIgKIq38DY3xDYpkb_5zTJYu1Wk7kwzUWJU-IYN8KM4yTYCIE888hcDc_ADFZXMoF0wwWwU9fusoHAouwO11Y9RCsS-&ir=1&rr=12".
_createXHR @ /usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:255
createXHR @ /usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:83
XhrFunction @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:30090
mediaSegmentRequest @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:41073
updateTransmuxerAndRequestSegment_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:44473
loadSegment_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:44439
fillBuffer_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43392
monitorBufferTick_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43336
setTimeout (async)
monitorBuffer_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43324
load @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:42976
load @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:49571
setCurrentTime @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:50086
setCurrentTime @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:52565
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:52083
data.dispatcher @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:2211
seeking (async)
setCurrentTime @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:20145
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:49637
removeFinished @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43280
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:45431
/usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:255 XHR failed loading: GET "https://r1---sn-n4g-jqbek.googlevideo.com/videoplayback?expire=1622190277&ei=ZVSwYMDRLcXN0wW-r6XYCA&ip=81.67.182.221&id=o-APy32QPN_YFl3w57KQKjHHk5IiysPGUkcJnPfEkZqdRj&itag=140&source=youtube&requiressl=yes&vprv=1&mime=audio%2Fmp4&ns=ud8VfIyzGFucXxKbh7caRaQF&gir=yes&clen=2912015&dur=179.884&lmt=1622134693784300&keepalive=yes&fexp=24001373,24007246&c=WEB&txp=5532434&n=QHFOO-_AKpHu5nHxSp&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&ratebypass=yes&sig=AOq0QJ8wRAIhAJxgIInVXTsQjJTJGgcsvCQY4hWYnieShFm4cureE85CAh8tSqKdE_kYR-gJfoxax78dYwf3sTQXFT9JhNrYSh23&redirect_counter=1&cm2rm=sn-n4g-nmc67e&req_id=6a37cfc2b296a3ee&cms_redirect=yes&ipbypass=yes&mh=1c&mm=29&mn=sn-n4g-jqbek&ms=rdu&mt=1622168447&mv=m&mvi=4&pcm2cms=yes&pl=23&lsparams=ipbypass,mh,mm,mn,ms,mv,mvi,pcm2cms,pl&lsig=AG3C_xAwRgIhAJhp6PdXV5HkcMc9Bc4pBu8AUqXOxh7F2HzYIS3RJrFNAiEA_XrITrDj5k4cBYV5ncI9Hc-jzyE6lhwkW7pTs0PsIpo%3D&ir=1&rr=12".
_createXHR @ /usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:255
createXHR @ /usr/lib/freetube/app.asar/node_modules/@videojs/xhr/index.js:83
XhrFunction @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:30090
mediaSegmentRequest @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:41073
updateTransmuxerAndRequestSegment_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:44473
loadSegment_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:44439
fillBuffer_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43392
monitorBufferTick_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43336
setTimeout (async)
monitorBuffer_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:43324
handleAppendsDone_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:45031
checkAppendsDone_ @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:44828
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:45298
shiftQueue @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:45216
(anonymous) @ /usr/lib/freetube/app.asar/node_modules/video.js/dist/video.cjs.js:45435







maplepy avatar May 28 '21 02:05 maplepy

Hope this helps

maplepy avatar May 28 '21 02:05 maplepy

Thanks for posting, it'll take a bit to figure out, as I am currently working on testing and merging the pull requests.

But it definitely looks like something cannot be requested properly from the image above.

GilgusMaximus avatar May 28 '21 14:05 GilgusMaximus

I’m using a VPN if that helps, used IVPN and Mullvad and I got the same problem with both

maplepy avatar May 30 '21 03:05 maplepy

I mean that could theoretically be the problem, but we'd need some more analytical testing. But as long as almost no one is able to reproduce it, this is difficult. Which country are you using for Mullvad?

GilgusMaximus avatar May 31 '21 10:05 GilgusMaximus

I used UK, Swiss, Luxemburg, Germany and France and I got the problem with all of those

maplepy avatar May 31 '21 12:05 maplepy

Okay I can confirm the VPN is not the problem. I also use Mullvad and I do not have these problems. But as it it seems there are some other problems atm with the player, so we will likely have to pick that up once again anyways

GilgusMaximus avatar Jun 01 '21 14:06 GilgusMaximus

Happens in this vid too https://www.youtube.com/watch?v=WRJaCxvkHUk&t=0

https://user-images.githubusercontent.com/73130443/136694454-4044c517-dc4c-4f81-af04-c26709cb69a6.mp4

This happens in some other videos of the same creator too but in other videos of him it doesnt happen. All the videos have qualities up to 2160p 60fps

Happens in this vid too https://www.youtube.com/watch?v=WRJaCxvkHUk&t=0

Happens in every video tbh, it's not content creator or topic specific

maplepy avatar Oct 12 '21 07:10 maplepy

It's back

maplepy avatar Mar 21 '22 00:03 maplepy

Not all videos are subject to the bug though:

These ones are:

  • https://youtu.be/8JUhoRWwOtM
  • https://youtu.be/_72cQVOqINI
  • https://youtu.be/cnDyon0nqes

These ones aren't:

  • https://youtu.be/hBYbodmCBUQ
  • https://youtu.be/MYNKPjpwCmU

but all of them are affected by this bug #1810

maplepy avatar Mar 21 '22 01:03 maplepy

image

also got this error instead of the crash

maplepy avatar Mar 21 '22 04:03 maplepy

that is also a known one that is annoying me https://github.com/FreeTubeApp/FreeTube/issues/761

that is also a known one that is annoying me #761

Weird thing is that it was fixed some months ago but some fixed bugs are coming back it seems like

maplepy avatar Mar 24 '22 04:03 maplepy

that's not fixed in the nightly build it seems like

maplepy avatar May 22 '22 16:05 maplepy

image

v0.17.1 Beta

maplepy avatar Sep 15 '22 23:09 maplepy

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 27 '22 01:12 github-actions[bot]

Still relevant

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 27 '23 01:01 github-actions[bot]

Don't close it

maplepy avatar Jan 27 '23 20:01 maplepy

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 01 '23 02:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 30 '23 01:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 28 '23 01:04 github-actions[bot]

Don't close it

Don't close it

Yeah the bot is extremely annoying

maplepy avatar Apr 28 '23 20:04 maplepy