FreeCAD
FreeCAD copied to clipboard
FreeCAD
Gui: Update splashscreen to use multiple images
Added new splashscreens that showcases addons and models from different creators. Made the splashcreen randomly select one at startup. Also disabled the splashscreen messages (it's unnecessary + disabling it GREATLY improves startup time).
Some images seem to be pixelated and have a white border
This one is also pixelated and has a white border. Also here, the image including shadow is going to the edge of the image which results in a sharp border at the bottom. The idea of the shadow should be, that it slowly fades out towards the edge of the image so there are at least full transparent pixels before there is the border of the image:
This one seems blurred and very dark:
Also, still not sure about promoting some addons directly, @chennes there was a similar discussion for the start page, which addons should be featured?
@maxwxyz You're looking at the 2x versions while zoomed in. Those problems on the normal versions are barely noticeable and don't pose any visual problems. I agree not all of them are perfect but there's sadly no way I can get a perfect borderless backgroundless png of all (or any really) of them. Also the reason some of them are pixelated is because they were screenshotted by their creators without AA on (which is the default for FreeCAD I believe, or used to be at least).
We can ofc remove the ones that are bad but I don't think any of them are really that problematic as I previously said.
Also I personally don't think promoting "some" addons is a problem. Those addons are clearly well-made and have a lot of users, plus they fill gaps in the FreeCAD workflow which new users might find useful. And having them there indirectly promotes other addons as well since it incentivizes the user to go to the Addon Manager.
Another plus, we can easily rotate the promoted addons with every release.
@qewer33 can you please confirm that we have explicit permission each of these images and projects?
@qewer33 can you please confirm that we have explicit permission each of these images and projects?
I've asked all the model creators for explicit permission (and they have confirmed) except the FOSS projects (Thor, SnakeOil, LumenPnP, M2) and addons (but we don't need permissions for addons right? the images are from the wiki). I figured we could use their images (I screenshotted some myself from their files too) since they're FOSS + we're crediting them anyway. But if it's a problem I can open issues on their repos and ask the maintainers.
OSS projects (Thor, SnakeOil, LumenPnP, M2)
@qewer33 i bumped 3 out of 4 of them on twitter. Don't know who M2 belongs to.
i bumped 3 out of 4 of them on twitter. Don't know who M2 belongs to.
Thanks! I actually pinged the M2 guy on Discord a couple days ago but he hasn't replied.
Thanks! I think as a matter of courtesy we should try to reach out to everyone involved so they know we are showcasing their work (and if they object of course we will remove it).
Hi, I'm Chip from SnakeOil 3d printer project. Please go ahead. If there is something I can help, fell free to ping me.
What is the reason to change image size? It would be also nice to have clean commit history. You can pick it from 3x380V:splash branch (a side product of testing plus some cleanup commits from my attempt #15435)
What is the reason to change image size?
It should be pretty close to the older image size anyway, if it poses a problem I can resize them but they're fine imo.
It would be also nice to have clean commit history. You can pick it from 3x380V:splash branch (a side product of testing plus some cleanup commits from my attempt #15435)
I'll take a look later, thanks.
:wave: @angellm would you give us consent to use Thor as one of the splashscreen images in the upcoming 1.0 release ?
:wave: @sphawes would you give us consent to use LumenPnP as one of the splashscreen images in the upcoming 1.0 release ?
👋 @AngelLM would you give us consent to use Thor as one of the splashscreen images in the upcoming 1.0 release ?
👋 @sphawes would you give us consent to use LumenPnP as one of the splashscreen images in the upcoming 1.0 release ?
Absolutely! It would be a great honour! 😄
👋 @sphawes would you give us consent to use LumenPnP as one of the splashscreen images in the upcoming 1.0 release ?
Absolutely! Thank you so much for considering us for the splashscreen!
The best CAD image to use is of the newest version (which is being released very soon) that you can find here: https://github.com/opulo-inc/lumenpnp/blob/rev05-mobo/img/v4-cad-hero.png
Please let me know if you'd like a different resolution, file format, etc.
It would be rather cool if projects on the splash screen will be bundled as examples. What do you think?
Alright I cleaned up the commit history (also @3x380V I cherry-picked your fix commits as well), we have permissions for every model in this PR (other than the Fasteners, SheetMetal and Gears addons but their images are taken from the wiki anyway) so it should be ready for merging now @chennes.
Also this is just the initial PR for the initial RC, I will open new PRs that add more splashes (and maybe a dark/light splash theme system) for later RCs and the actual release.
@qewer33 Could we use this image for the LumenPnP image instead? The one currently there is an old version of the machine. Happy to do any photoshop to have it fit the format if you'd like!
@qewer33 Could we use this image for the LumenPnP image instead? The one currently there is an old version of the machine. Happy to do any photoshop to have it fit the format if you'd like!
Oh I forgot about that, sorry. Can you take a screenshot from a more isometric angle (like the one on the current splash) perhaps? That would look nicer, thanks!
Thank you @sphawes! Does this look good? I tweaked the colors slightly to make it pop a little better, I'll push it if you approve.
Should be ready for merge now
@qewer33, looks good, thank you. Could you squash and rebase? People does not seem to do it here on merge...
Could you squash and rebase? People does not seem to do it here on merge...
What's wrong with the current commit history? Other than the fixup commits.
@qewer33 what's the status regarding author permissions? Do we have the permission of everybody? Is this ready for merge?
@qewer33 what's the status regarding author permissions? Do we have the permission of everybody? Is this ready for merge?
Yep! We have permissions for everything (other than the Sheet Metal, Gears and Fasteners addons as I mentioned but their images are taken from the wiki and they're inside the FreeCAD ecosystem so) and the PR is ready for merge.
i bumped 3 out of 4 of them on twitter. Don't know who M2 belongs to.
Thanks! I actually pinged the M2 guy on Discord a couple days ago but he hasn't replied.
@qewer33 can you get M2 project to consent on this ticket ?
What's wrong with the current commit history? Other than the fixup commits.
Other than that it is perfectly fine!