Calendar
Calendar copied to clipboard
Save/discard changes dialog is not triggered for certain edits
Checklist
- [x] I can reproduce the bug with the latest version.
- [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
- [x] I have read the FAQ and my problem isn't listed.
- [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- [x] This issue contains only one bug.
- [x] I have read and understood the contribution guidelines.
Describe the bug When editing an event and pressing the back button, a dialog is displayed asking if the changes should be saved or discarded. However, this dialog is missing and the changes are not saved when editing the following fields:
- time zone
- recurrence end (the other recurrence settings do trigger the dialog)
- attendees (addition, removal, attendance status)
- free/busy status
To Reproduce Steps to reproduce the behavior:
- Open a CalDAV event.
- Add or remove attendees.
- Press the back button.
- The save/discard changes dialog is not shown.
Expected behavior The dialog to save or discard the changes is shown.
Screenshots
screen recording
https://github.com/FossifyOrg/Calendar/assets/97251923/e5dc9413-3e6e-4f80-af4b-365695e18111
Device info (please complete the following information):
- Model: Google Pixel 6a
- OS: Android 14 (GrapheneOS)
- Version: 1.0.2
Additional context N/A
I noticed that some other fields are affected as well. So I added them to the issue description.
Wanted to add that the problem goes a bit further: when using the back button (instead of the gesture) after a calendar entry edit, the dialog never shows up and the edits aren't saved. This is kind of dangerous for critical events :P
I'd also swap the positioning of the icons for "delete" and "duplicate".