vue-fontawesome icon indicating copy to clipboard operation
vue-fontawesome copied to clipboard

Published 20 hours ago • verified publisher icon FortAwesome

fix: Type definitions for Vue 3 Composition API

Open parkeyparker opened this issue 3 years ago • 1 comments

FontAwesomeIcon and other components needed to be of type DefineComponent for Vue 3 Composition API TypeScript support (as per #276). The type definitions for the component props also needed updating to denote required and optional props.

Whilst checking which props were required it was noted that the FontAwesomeLayer component uses fixedWidth but the README and example use full-width so these have been updated to match the component code.

parkeyparker avatar Mar 04 '22 16:03 parkeyparker

Hey, thanks @parkeyparker. We'll take a look at this when we can.

robmadole avatar Apr 06 '22 02:04 robmadole

Any updates on this PR? Recent changes to Volar (Vue extension for VSCode) show an error for the font awesome component and this PR fixes that.

nielsvanvelzen avatar Oct 10 '22 09:10 nielsvanvelzen

I've rebased my changes onto the latest code on the 3.x branch which should hopefully make it ready for review and merge. Any issues please let me know and I'll get them addressed as quick as I can.

parkeyparker avatar Oct 17 '22 19:10 parkeyparker

This is open since April... Our project build breaks due to this. What's stopping you from merging?

datrinh avatar Oct 24 '22 16:10 datrinh

Pleeeease merge this!

plehnen avatar Oct 26 '22 08:10 plehnen

What's stopping you from merging?

dalirnet avatar Oct 30 '22 18:10 dalirnet