nuka-carousel icon indicating copy to clipboard operation
nuka-carousel copied to clipboard

Published 20 hours ago • verified publisher icon FormidableLabs

Remove defaultProps for React 18.3.0

Open Shoreasg opened this issue 2 years ago • 1 comments

Nuka Version: 5.41 React Version: 18.2.0 Chrome

Problem Carousel: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. Getting this error due to this PR

https://github.com/jsx-eslint/eslint-plugin-react/issues/2396 https://github.com/facebook/react/pull/16210

Need to fix this before the release of react 18.3.0

Shoreasg avatar Feb 11 '23 06:02 Shoreasg

Just wanted to mention, we're now hitting this in nextjs 13.4 with app router - it's shipping a canary of React that has the deprecation warning.

Looking at the code, it seems to be a one-line change to fix it. I'll open a simple PR.

VanTanev avatar Jun 06 '23 15:06 VanTanev

With the release of Nuka v8, defaultProps have been removed from the codebase

carbonrobot avatar Apr 05 '24 18:04 carbonrobot