Forbes Lindesay

Results 267 comments of Forbes Lindesay

The 404 case is an interesting one. I have to admit that I hadn't considered that. I think it would be preferable to throw that error, rather than passing it...

I mean, when you write wiki pages in github, you write them in markdown. It would be good to be able to view these in DocumentUp in the same way...

Yeh, the advantage would be that in most repositories, anyone can edit the wiki pages, so they are sometimes more detailed/complete, and when they have errors in the markdown that...

Yeh, I think you're right.

The problem here is that at present node.js does not support a synchronous http request (I wish it would) so you have to cache it before you can `include` it...

Why don't you just use a shim? ``` js if (!String.prototype.trim) { String.prototype.trim = function () { return this.replace(/^\s+|\s+$/g,''); } } ``` Why should this be the responsibility of the...

IE8 is not mentioned anywhere in the readme, and it doesn't work on IE8, so I assume it doesn't support IE8.

My thinking with include was still that it would be at compile time that we loaded the file and included it, only how we call it would be different. I'm...

As for layouts, I think the inheritance chains are really important. I implemented it in [QEJS](https://github.com/JEPSO/QEJS) and I use it all the time. I typically have one base layout that's...

I also think the inheritance chains would be pretty simple to implement because you'd just be calling into the ejs compile function of the parent, which could then do all...