Flux.jl
Flux.jl copied to clipboard
Fix the last remaining 404 errors
The only thing keeping me from making the cross reference check strict -
strict = [:cross_references]
is the failing isnumeric hyperlink (https://fluxml.ai/Flux.jl/stable/training/optimisers/#Optimisers.destructure), which does not have a docstring in Optimisers.jl.
PR Checklist
- [ ] Tests are added
- [ ] Entry in NEWS.md
- [ ] Documentation, if applicable
Nice! @mcabbott should we slap a docstring onto isnumeric or scrub the dangling reference to it in https://github.com/FluxML/Optimisers.jl/blob/9b75dbb0d80e4e383eab279345a70d4b567721ea/src/destructure.jl#L8?
Could go either way. I made https://github.com/FluxML/Optimisers.jl/pull/104 to see how it looks.
I will fix the reference here once https://github.com/FluxML/Optimisers.jl/pull/104 is merged!
Temporarily fixed the references for the API of OneHotArrays.jl. See #2038.
If you wouldn't mind looking into the doctest failure, we can get this merged.
- The regex pattern is getting out of hand 😅 but now it captures
Float32values too (which were causing the CI to fail). Documenter.jlwas outdated and was not allowingstrictto be of the typeVector{Symbol}.
I think a new release for Optimisers.jl is required for the tests to pass. The CI is still not picking up the docstring for Optimisers.isnumeric.
(Test out the regex here - https://regex101.com/r/THfO8E/1)
I think a new release for
Optimisers.jlis required for the tests to pass. The CI is still not picking up the docstring forOptimisers.isnumeric.
Ok, I was wondering why it worked given that wasn't tagged! Have another try after https://github.com/JuliaRegistries/General/pull/66169.
Have another try after https://github.com/JuliaRegistries/General/pull/66169.
Everything works now!