vhs icon indicating copy to clipboard operation
vhs copied to clipboard

v:page.languageMenu - Lower case flag image src

Open christophgg opened this issue 6 years ago • 1 comments

Hi @NamelessCoder,

first of all thanks for your work on this very useful extension! ;)

I've noticed a small bug which might be related more to the core than to the VHS extension itself: The function getLanguageFlagSrc in the viewhelper page.languageMenu returns the ISO code always in upper case, but the typo3 core currently contains three image files with names in lower case, especially en-us-gb.png. On systems with case sensitivity this causes an error (e.g. in the f:image viewhelper) because the image file can't be found.

Should this be changed in the core by naming all image files consistently or should there be a workaround applied to the viewhelper's function?

Thanks for your evaluation in advance!

christophgg avatar Jan 22 '19 14:01 christophgg

Hi Christoph,

Should this be changed in the core by naming all image files consistently or should there be a workaround applied to the viewhelper's function?

The easy choice would be to simply add a check in VHS for a lowercase version of the filename - and then report the inconsistency to TYPO3. It would also make sense to investigate if another property than the iso code contains the flag image name, if so we should of course read from there instead.

NamelessCoder avatar Feb 04 '19 11:02 NamelessCoder