Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Reindex when app install or deleted (and uwp update).

Open taooceros opened this issue 3 years ago • 12 comments

Watch Program change to reindex (Program Plugin)

TODO:

  • [x] Bookmark reindex

Close #688

taooceros avatar Jan 08 '22 21:01 taooceros

Lets remove this mechanism https://github.com/Flow-Launcher/Flow.Launcher/blob/25cc50b9ac29f475ba56cb5205d518845b18432d/Plugins/Flow.Launcher.Plugin.Program/Main.cs#L27 now that we are adding the watcher in.

jjw24 avatar Jan 27 '22 10:01 jjw24

Lets remove this mechanism

https://github.com/Flow-Launcher/Flow.Launcher/blob/25cc50b9ac29f475ba56cb5205d518845b18432d/Plugins/Flow.Launcher.Plugin.Program/Main.cs#L27 now that we are adding the watcher in.

Should we reindex on startup at background?

taooceros avatar Feb 06 '22 23:02 taooceros

@taooceros I have been testing this, I can't get Win32 and uwp app change detections to work. Can you check please.

jjw24 avatar Feb 21 '22 10:02 jjw24

@taooceros I have been testing this, I can't get Win32 and uwp app change detections to work. Can you check please.

Finally get some workable free time. I will check now.

taooceros avatar Feb 21 '22 21:02 taooceros

The firefox bookmark works partially when the bookmark is added to bookmark folder that is not the bookmark tool bar? I don't know how firefox handle that but if the bookmark is added to the toolbar, the sqlite file won't change.

taooceros avatar Feb 21 '22 21:02 taooceros

@jjw24 I forget to reset cache when reindex. Now it should work (at least work for uwp).

taooceros avatar Feb 21 '22 21:02 taooceros

@jjw24 what's your uwp version? We are using a relatively new winrt api so probably that won't work in earlier version? (just similar to the windows notification)

taooceros avatar Mar 01 '22 19:03 taooceros

I tested with Snip & Sketch via Microsoft's App Store.

Does it work for you? What UWP app did you test?

jjw24 avatar Mar 02 '22 09:03 jjw24

I tested with Snip & Sketch via Microsoft's App Store.

Does it work for you? What UWP app did you test?

Sorry I mean the windows version.

taooceros avatar Mar 02 '22 13:03 taooceros

I tested with Snip & Sketch via Microsoft's App Store.

Does it work for you? What UWP app did you test?

I test it with netflix.

taooceros avatar Jun 10 '22 23:06 taooceros

Would you mind take a debug on whether the events are triggered if that doesn't work?

taooceros avatar Jun 10 '22 23:06 taooceros

I wonder probably we can make the reindex faster by deleting the uninstalled entry/adding new entry. But the current way is good enough for now since it is unlikely that it will requires a lot of resources.

taooceros avatar Jun 10 '22 23:06 taooceros

The firefox bookmark works partially when the bookmark is added to bookmark folder that is not the bookmark tool bar? I don't know how firefox handle that but if the bookmark is added to the toolbar, the sqlite file won't change.

With Firefox (v104.0) bookmarks, I have found when a bookmark is added or removed, the surest way that places.sqlite will get updated is when you close all Firefox browser. Occasionally it may update after adding/ removing a bookmark. Chrome and Edge on the other hand their file get updated almost instantly after adding/removing a bookmark. This is fine with Firefox as it is beyond our control when the places.sqlite file get updated.

jjw24 avatar Aug 29 '22 19:08 jjw24

Tested on Windows [Version 10.0.19044.1949]:

  1. Chrome (v104.0.5112.102) bookmarks work
  2. Edge (v104.0.1293.70) bookmarks work
  3. Firefox (v104.0) bookmarks work
  4. Installing & removing UWP apps (Netflix, Snip & Sketch) installed from Microsoft Store work
  5. Installing & removing Win32 apps work (Firefox v104.0)

jjw24 avatar Aug 29 '22 19:08 jjw24