Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Implement PluginSearch TextBox & ContentControl Lazy Load

Open taooceros opened this issue 3 years ago • 8 comments

taooceros avatar Dec 11 '21 17:12 taooceros

looks like it's still WIP? i will mark it as draft

jjw24 avatar Dec 19 '21 09:12 jjw24

search is not working, tried pressing enter too.

jjw24 avatar Feb 07 '22 09:02 jjw24

search is not working, tried pressing enter too.

works for me. What's your behavior?

taooceros avatar Feb 12 '22 21:02 taooceros

Tried it again and still the Plugin Store's search is not working. I removed entire flow user data then rebuilt and ran. Went into plugin store tab and clicked on the search text, put in a search term 'colors' and pressed enter. Nothing happens.

Search is however working for me in the plugins tab.

Also:

  • can we add Ctrl + F focus to the Plugin Store search text box please
  • add a tooltip to both tabs so when hovering over the search text box it displays something like 'Ctrl + F to search plugins'

jjw24 avatar Feb 13 '22 22:02 jjw24

Tried it again and still the Plugin Store's search is not working. I removed entire flow user data then rebuilt and ran. Went into plugin store tab and clicked on the search text, put in a search term 'colors' and pressed enter. Nothing happens.

Search is however working for me in the plugins tab.

Also:

* can we add Ctrl + F focus to the Plugin Store search text box please

* add a tooltip to both tabs so when hovering over the search text box it displays something like 'Ctrl + F to search plugins'

Ah I get your idea🤣I haven't implemented the plugin store search. I will fix that later.

taooceros avatar Feb 13 '22 22:02 taooceros

  • Plugin Store works. Plugin list doesn't works.

  • It is good to be searched when entering the enter key, but if the search box is empty, it is necessary to initialize it.

  • Can we add label in this PR? (installed, update, etc...) if so, we need more works with install button. (update, disabled...)

  • other topic. we need something to message when no result / no connection.

onesounds avatar Sep 20 '22 11:09 onesounds

It is good to be searched when entering the enter key, but if the search box is empty, it is necessary to initialize it.

That's pretty slow though, because empty means there are most plugins that needs to be rendered. Though it makes sense. We can add a LostFocus event for that.

taooceros avatar Sep 20 '22 13:09 taooceros

Oh we already have the lostfocus event. I don't want to filter while user typing because that will create unhappy typing experience. If later we find ways to optimize the render, we can revise the behavior.

taooceros avatar Sep 20 '22 13:09 taooceros

this is ready for review?

jjw24 avatar Sep 27 '22 11:09 jjw24

this is ready for review?

yep. There are 'installed' labels or a few more features I want to add, but I think it would be better to do it in another pr. The search itself works well.

onesounds avatar Sep 27 '22 11:09 onesounds