Flow.Launcher
Flow.Launcher copied to clipboard
Flow-Launcher
Added trim support to reduce size of installation & spellfix Caculator
I check the nuget package for Microsoft.Tools.Trimings, and it hasn't been updated since 2018. Therefore, I think it would be better to use the publish triming. https://docs.microsoft.com/en-us/dotnet/core/deploying/trimming/trim-self-contained#:~:text=Trimming%20is%20only%20supported%20in.NET%206%2B.%20Components%20that,external%20dependencies%20that%20aren%27t%20visible%20at%20build%20time.
I have tested that implementation and it does not work. I have got the publishing tools to work using the nuget package and it does work. You are using the 'if update then do' which in the world of software... is more of a hope than a requirement. For instance, as to my knowledge we are not updating to .net6 yet. I can look at it again, but if it ain't broke... don't break it.
On Sun, Nov 14, 2021 at 4:10 PM Kevin Zhang @.***> wrote:
I check the nuget package for Microsoft.Tools.Trimings, and it hasn't been updated since 2018. Therefore, I think it would be better to use the publish triming. https://docs.microsoft.com/en-us/dotnet/core/deploying/trimming/trim-self-contained#:~:text=Trimming%20is%20only%20supported%20in.NET%206%2B.%20Components%20that,external%20dependencies%20that%20aren%27t%20visible%20at%20build%20time .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Flow-Launcher/Flow.Launcher/pull/804#issuecomment-968372943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUWT2SBJNJJSG6OYZINTALUMAXWTANCNFSM5HYLCDHA .
cl build?
On Mon, Nov 15, 2021 at 8:28 AM Kevin Zhang @.***> wrote:
Could you take a check on the error popped out in the CI build?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Flow-Launcher/Flow.Launcher/pull/804#issuecomment-968964543, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUWT2S3473BFBMMPCVBGALUMEKJBANCNFSM5HYLCDHA .
it's coming from the bumping the nuget package to 5.11 https://ci.appveyor.com/project/JohnTheGr8/flow-launcher/builds/41525939
i noticed the userdata's folder name has not been corrected:
but if we correct this then we need to provide backwards compatibility for users that may have change from the default option in the plugin settings.
@XavBryant i recommend separating the two changes because we may need to test the trim support for a bit assuming this is the change to trim down the release package size
all I did was describe how to do the trim. id suggest someone else implement trim as I would have to redownload installation.
On Mon, Nov 15, 2021 at 3:29 PM Jeremy Wu @.***> wrote:
@XavBryant https://github.com/XavBryant i recommend separating the two changes because we may need to test the trim support for a bit assuming this is the change to trim down the release package size
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Flow-Launcher/Flow.Launcher/pull/804#issuecomment-969339141, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUWT2U42C5ENNSNMNZTAJDUMF3T5ANCNFSM5HYLCDHA .
Microsoft.Packaging.Tools.Trimming was an early experiment we did to demonstrate the possibilities of assembly level trimming. This predated official support.
You should use the built-in trimming support: https://docs.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options
Microsoft.Packaging.Tools.Trimmingwas an early experiment we did to demonstrate the possibilities of assembly level trimming. This predated official support.You should use the built-in trimming support: https://docs.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options
Hi, the issue with the built in support of trimming is that it cannot run properly for wpf apps, while the experimental trimming tool seems working.