Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Add github dependency bot

Open taooceros opened this issue 4 years ago • 14 comments

Add automatic check for dependency update

taooceros avatar Jun 23 '21 07:06 taooceros

Upping the versions will require testing, would it not be better to test while you are choosing to upgrade the version?

This will create a lot of noise in the pr section

jjw24 avatar Jun 23 '21 07:06 jjw24

Upping the versions will require testing, would it not be better to test while you are choosing to upgrade the version?

This will create a lot of noise in the pr section

We can make that check weekly/monthly, which means it will only create a version update pr once a week/month. In most situation, we don't update version because we are lazy to update hhh🤣 (or not notice there's an update).

taooceros avatar Jun 23 '21 07:06 taooceros

Isn't this going to run through and create a pr for every version upgrade? This is going to create a fair bit prs.

Again you have to test to do the upgrade, which I would prefer effort put into enhancements instead and upgrade the required packages if needed

jjw24 avatar Jun 23 '21 07:06 jjw24

Isn't this going to run through and create a pr for every version upgrade? This is going to create a fair bit prs.

I don't think so. It shall create one pr once a week for all update if it has detected an update.

Again you have to test to do the upgrade, which I would prefer effort put into enhancements instead and upgrade the required packages if needed

Unless there's a breaking change (like squirrel), I don't think updating the a dependency will require a lot of testing.

taooceros avatar Jun 23 '21 07:06 taooceros

We have a lot of old packages, it's going to upgrade a lot of them.

Can you check how many updates it will create for please

jjw24 avatar Jun 23 '21 08:06 jjw24

I will take a try in my fork first.

taooceros avatar Jun 23 '21 08:06 taooceros

image It will behave like this. Each update with an pull request, and it will list the release note and commit difference for each update. https://github.com/taooceros/Flow.Launcher/pull/10

taooceros avatar Aug 07 '21 02:08 taooceros

only 5 packages need updating?

jjw24 avatar Aug 08 '21 08:08 jjw24

only 5 packages need updating?

No, it is because we can limit the count of pr created one time (which is 5)

taooceros avatar Aug 08 '21 09:08 taooceros

Would it be better before applying the bot to make an individual branch, upgrade all the non-breaking upgrades on this branch, test them out and merge into dev first?

jjw24 avatar Aug 08 '21 12:08 jjw24

Would it be better before applying the bot to make an individual branch, upgrade all the non-breaking upgrades on this branch, test them out and merge into dev first?

Sounds reasonable

taooceros avatar Aug 08 '21 12:08 taooceros

@jjw24 shall we merge the dependabot?

taooceros avatar Sep 01 '22 15:09 taooceros

We have a lot of prs in the pipeline atm, will this change add a lot more? If so can we bump all NuGet packages on a seperate branch, test everything ok and merge in before merging this one so we start with a good baseline.

jjw24 avatar Sep 05 '22 11:09 jjw24

You can limit the maximum PR's dependabot is able to create with: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit

Garulf avatar Sep 12 '22 18:09 Garulf

You can limit the maximum PR's dependabot is able to create with: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit

the default is 5, which I think is quite reasonable

taooceros avatar Sep 22 '22 04:09 taooceros

Seems reasonable to me. Our tests will still run on each PR so in theory we get updated packages for free.

Garulf avatar Sep 22 '22 21:09 Garulf

Ok let's merge this after 1.9.5

jjw24 avatar Sep 22 '22 23:09 jjw24

Shall we merge this? @jjw24

taooceros avatar Oct 11 '22 21:10 taooceros