Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Fix ci hanging on md file changes

Open jjw24 opened this issue 4 years ago • 12 comments

AppVeyor ci build hangs when only changes are MD files

jjw24 avatar May 12 '21 11:05 jjw24

We have configured AppVeyor to skip commits that only change markdown files, because building those isn't really necessary... Is this an issue?

JohnTheGr8 avatar May 19 '21 04:05 JohnTheGr8

Yeah I think it is still an issue, will test later

jjw24 avatar May 19 '21 09:05 jjw24

nop still no good image

jjw24 avatar May 19 '21 22:05 jjw24

image

jjw24 avatar May 19 '21 22:05 jjw24

I knew what you meant, you didn't need to test it... This is more or less expected behavior, AppVeyor never starts a build for these commits, and Github waits for a build success notification that never comes.

If you feel this is a big annoyance, we can remove the lines I mentioned earlier from appveyor.yml... Or you can use your superpowers to force merge such PRs, they only come once in a while anyway...

JohnTheGr8 avatar May 20 '21 03:05 JohnTheGr8

If we remove that line, AppVeyor will build for md changes and return a status?

jjw24 avatar May 20 '21 03:05 jjw24

Let's do that

jjw24 avatar May 20 '21 03:05 jjw24

Is it possible to simply return success when only md is changed is appveyor?

taooceros avatar May 20 '21 04:05 taooceros

Is it possible to simply return success when only md is changed is appveyor?

Seems like there is no standard way to do that, no.

Let's do that

In my opinion this is a minor annoyance that happens rarely enough that it can be overlooked... it only affects PRs whose last commit changes markdown files only. By removing the skip of such commits, we will be stressing a free service unnecessarily on every commit that simply changes the Readme, etc. I think it's a small price to pay...

JohnTheGr8 avatar May 20 '21 09:05 JohnTheGr8

yeah that's fine

jjw24 avatar May 20 '21 20:05 jjw24

We can do something like this. https://github.com/appveyor/ci/issues/1848#issuecomment-712738861

taooceros avatar Jul 19 '21 02:07 taooceros

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 14 '22 02:07 github-actions[bot]