Display notify icon before loading plugins to tell users that Flow is loading.

If plugin initialization causes much time, it could be helpful for users to know Flow has started already

Jun 07 '25 12:06 Jack251970

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files. Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

	Jack251970	onesounds
JUN
MAY	13 additions & 4 deletions
APR	73 additions & 40 deletions	3 additions & 0 deletions
MAR	168 additions & 94 deletions
FEB	79 additions & 40 deletions
JAN	86 additions & 66 deletions

Knowledge based on git-blame: Jack251970: 67%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970	onesounds
JUN	65 additions & 67 deletions	85 additions & 15 deletions
MAY	140 additions & 43 deletions	5 additions & 1 deletions
APR	69 additions & 45 deletions	5 additions & 1 deletions
MAR	1141 additions & 1076 deletions	327 additions & 141 deletions
FEB	1 additions & 1 deletions	8 additions & 4 deletions
JAN

Knowledge based on git-blame: Jack251970: 67%

To learn more about /:\ gitStream - Visit our Docs

Jun 07 '25 12:06 gitstream-cm[bot]

Be a legend :trophy: by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Jun 07 '25 12:06 gitstream-cm[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it, try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jun 07 '25 12:06 github-actions[bot]

[!WARNING]

Rate limit exceeded

@Jack251970 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between da88fa4311f760678b6582c90e5a44f3e219a2ad and 736d96ea95338500eee13cfcaed46e8277604dfc.

📒 Files selected for processing (1)

Flow.Launcher/App.xaml.cs (5 hunks)

📝 Walkthrough

Walkthrough

The changes refactor the management of the application's system tray notify icon by moving its instantiation and configuration from the MainWindow class to a new static property in the App class. All notify icon references in MainWindow are updated to use this centralized static instance.

Changes

File(s)	Change Summary
Flow.Launcher/App.xaml.cs	Added static `NotifyIcon` property and `InitializeNotifyIcon` method; moved notify icon setup here.
Flow.Launcher/MainWindow.xaml.cs	Removed instance `_notifyIcon` field; updated to use `App.NotifyIcon`; made `_contextMenu` static.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant MainWindow

    User->>App: Start application
    App->>App: InitializeNotifyIcon()
    App->>App: Set NotifyIcon properties and show icon
    App->>MainWindow: Create MainWindow
    MainWindow->>App: Use App.NotifyIcon for event handling and context menu

Suggested labels

Dev branch only

Suggested reviewers

jjw24
onesounds

Poem

In the tray a new icon glows,
Centralized where logic flows.
No more scattered, no more stray,
One static spot to rule the tray.
Rabbits cheer and hop with glee—
Refactored code for all to see!
🐇✨

✨ Finishing Touches

[ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Jun 07 '25 12:06 coderabbitai[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it, try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jun 07 '25 12:06 github-actions[bot]

Can you provide a screenshot please

Jun 16 '25 12:06 jjw24

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it, try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jun 16 '25 13:06 github-actions[bot]

Can you provide a screenshot please

? Just display a tray icon. And why we need a screenshot?

Jun 16 '25 13:06 Jack251970

I mean the notification icon

Jun 16 '25 13:06 jjw24

I mean the notification icon

Here you go.

Jun 16 '25 13:06 Jack251970

Hmm I am not sure if this will communicate that flow is loading. @onesounds thoughts?

Jun 16 '25 13:06 jjw24

Hmm I am not sure if this will communicate that flow is loading. @onesounds thoughts?

No. The click event is not registered until main window is loaded. This tray icon just displays there and left click or right click will not trigger anything

Jun 16 '25 13:06 Jack251970

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it, try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jun 16 '25 13:06 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it, try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jun 16 '25 13:06 github-actions[bot]

I've been looking at this PR for a while and honestly couldn't figure out what it's doing — but after reading your conversation, I finally get it. (Please write more detailed explanations in PR descriptions. You need to provide enough background so people can understand why the change is necessary. As it stands, I can't even tell how to properly test this.)

In my opinion, this approach isn't ideal. The way I understand this PR, Flow will not respond even if the tray icon is visible — but that could actually cause more user confusion. People might think "Flow is running, but clicking doesn't do anything." In fact, this might generate even more issue reports. (For example, when I debug, I usually interpret the tray icon as a definite signal that Flow is running and responsive. According to this PR, even if the tray icon is present, Flow may or may not be functional.)

I am a bit curious to see how Jack would suffer from conflicting issue reports if this PR gets merged... but I think this problem should be addressed differently, and in the following priority order:

Flow startup should never be significantly delayed just because of plugin loading. This situation itself shouldn't exist.
If solving no.1 is too difficult and we need to provide user feedback, simply showing the tray icon isn’t enough. We should consider a better way. (I'm not sure what the best approach is — maybe using an OS-level notification? Obviously we can't put a loading animation in the tray icon.)
As I’ve said before: if Flow has to be frozen while plugins load, then it's better to just let it freeze.

If we absolutely need to implement this behavior, one idea would be:

Since the tray icon can be updated dynamically (like Discord does), we could display a different icon during the plugin loading phase.

When users click or right-click the icon, we could show a context flyout that says: "Plugins are still loading. Please wait."

If Flow is triggered via a hotkey during this time, we could show a temporary OS notification.

This is just a suggestion. Honestly, if the loading time isn’t too long, this method wouldn’t be a big issue either.

Jun 16 '25 21:06 onesounds

I've been looking at this PR for a while and honestly couldn't figure out what it's doing — but after reading your conversation, I finally get it. (Please write more detailed explanations in PR descriptions. You need to provide enough background so people can understand why the change is necessary. As it stands, I can't even tell how to properly test this.)

In my opinion, this approach isn't ideal. The way I understand this PR, Flow will not respond even if the tray icon is visible — but that could actually cause more user confusion. People might think "Flow is running, but clicking doesn't do anything." In fact, this might generate even more issue reports. (For example, when I debug, I usually interpret the tray icon as a definite signal that Flow is running and responsive. According to this PR, even if the tray icon is present, Flow may or may not be functional.)

I am a bit curious to see how Jack would suffer from conflicting issue reports if this PR gets merged... but I think this problem should be addressed differently, and in the following priority order:

Flow startup should never be significantly delayed just because of plugin loading. This situation itself shouldn't exist.

If solving no.1 is too difficult and we need to provide user feedback, simply showing the tray icon isn’t enough. We should consider a better way. (I'm not sure what the best approach is — maybe using an OS-level notification? Obviously we can't put a loading animation in the tray icon.)

As I’ve said before: if Flow has to be frozen while plugins load, then it's better to just let it freeze.

If we absolutely need to implement this behavior, one idea would be:

Since the tray icon can be updated dynamically (like Discord does), we could display a different icon during the plugin loading phase.

When users click or right-click the icon, we could show a context flyout that says: "Plugins are still loading. Please wait."

If Flow is triggered via a hotkey during this time, we could show a temporary OS notification.

This is just a suggestion. Honestly, if the loading time isn’t too long, this method wouldn’t be a big issue either.

Alright, let us close it

Jun 17 '25 01:06 Jack251970

Flow.Launcher Flow.Launcher copied to clipboard

Display notify icon before loading plugins

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

s.b. workaround(s)

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

s.b. workaround(s)

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

s.b. workaround(s)

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

s.b. workaround(s)

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

s.b. workaround(s)

Flow.Launcher
Flow.Launcher copied to clipboard

CodeRabbit Configuration File (`.coderabbit.yaml`)