Improve update logic & Fix update logic issue & Input for Query

[Jack251970]

From #3314. Resolve #2605.

Improve update logic

Improve main view model update logic.

Fix update logic issue

We should not use e.Query.RawQuery != QueryText because QueryText (Input) is different from RawQuery (Query).

Add new property Input for Query

Input is the property without trimming whitespace and it can help developer get the raw input.

Clear results when there are no update tasks

In this function, we need to reset all things because there are no update tasks.

if (ShouldClearExistingResultsForNonQuery(plugins))
{
    // No update tasks and just return
    ClearResults();
    return;
}

Test

• Input long string fast and interface will update instantly.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm[bot]]

Be a legend :trophy: by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[coderabbitai[bot]]

[!NOTE]

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Query now preserves both the original and trimmed user input: Query gained OriginalQuery and TrimmedQuery (deprecating RawQuery). QueryBuilder.Build signature changed to accept original+trimmed strings and propagates those into returned Query. Call sites across UI, VM, helpers, storage, plugins, and tests updated to use TrimmedQuery where previously RawQuery was used.

Changes

Cohort / File(s)	Change Summary
Query model Flow.Launcher.Plugin/Query.cs	Added OriginalQuery and TrimmedQuery (public, internal init). RawQuery kept as obsolete wrapper to TrimmedQuery. ToString() returns TrimmedQuery.
Query builder Flow.Launcher.Core/Plugin/QueryBuilder.cs	API changed: Build(string text, ...) → Build(string originalQuery, string trimmedQuery, ...). Uses trimmedQuery for parsing and sets OriginalQuery, TrimmedQuery, and IsHomeQuery on returned Query.
View & ViewModel Flow.Launcher/MainWindow.xaml.cs, Flow.Launcher/ViewModel/MainViewModel.cs	Updated call sites to Build(original, trimmed, plugins) (Backspace, ConstructQueryAsync). Replaced _isQueryRunning with _progressQuery and _updateQuery; refactored cancellation, progress visibility, result gating, and results-updated guards to use query tracking.
Helpers & Core plugin RPC Flow.Launcher/Helper/ResultHelper.cs, Flow.Launcher.Core/Plugin/JsonRPCPluginV2.cs	Updated method signatures/params to accept trimmed query and to construct Result/ResultUpdatedEventArgs with TrimmedQuery.
Storage & Records Flow.Launcher/Storage/QueryHistory.cs, Flow.Launcher/Storage/LastOpenedHistoryItem.cs, Flow.Launcher/Storage/TopMostRecord.cs	Replaced uses of OriginQuery.RawQuery with OriginQuery.TrimmedQuery for comparisons, keys, persistence, and queue operations.
Plugins Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs, Flow.Launcher.Core/Plugin/PluginManager.cs	Switched contexts/placeholders and autocomplete text to use TrimmedQuery instead of RawQuery.
UI controls Flow.Launcher/ResultListBox.xaml.cs	Internal state renamed (underscore-prefixed), lock type changed to Lock, drag/drop and click handlers updated to propagate TrimmedQuery.
Tests Flow.Launcher.Test/QueryBuilderTest.cs	Updated to new Build(original, trimmed, plugins) signature and adjusted assertions to validate TrimmedQuery.
Other call-sites Flow.Launcher/Helper/*, various	Multiple call sites updated to pass original and trimmed strings to QueryBuilder.Build and to reference TrimmedQuery rather than RawQuery.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant User
    participant MainWindow
    participant MainViewModel
    participant QueryBuilder
    participant Plugins
    Note over QueryBuilder: Build(originalQuery, trimmedQuery, nonGlobalPlugins)

    User->>MainWindow: type input
    MainWindow->>MainViewModel: Submit QueryText (raw)
    MainViewModel->>QueryBuilder: Build(raw, raw.Trim(), plugins)
    Note right of QueryBuilder `#eef6ff`: set OriginalQuery = raw\nset TrimmedQuery = raw.Trim()\nparse using trimmedQuery
    QueryBuilder-->>MainViewModel: Query{OriginalQuery, TrimmedQuery, IsHomeQuery,...}
    MainViewModel->>MainViewModel: set _progressQuery / _updateQuery
    MainViewModel->>Plugins: execute plugin queries (async, cancellable)
    alt query still current
        MainViewModel->>MainWindow: show progress + update results (use TrimmedQuery)
    else cancelled or superseded
        MainViewModel->>MainWindow: hide progress / ignore stale updates
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Focus review on MainViewModel.QueryResultsAsync and RegisterResultsUpdatedEvent for race conditions, cancellation handling, and correct clearing of _progressQuery/_updateQuery.
• Verify QueryBuilder.Build consistently sets OriginalQuery/TrimmedQuery (including home-query path).
• Confirm all call sites pass parameters in correct order (original first, trimmed second) and remove/replace remaining RawQuery usages.

Possibly related PRs

• Flow-Launcher/Flow.Launcher#4042 — touches QueryBuilder and ResultHelper call sites; intersects on Build signature and call-site updates.
• Flow-Launcher/Flow.Launcher#3588 — modifies Query model and IsHomeQuery handling similar to this change.
• Flow-Launcher/Flow.Launcher#3399 — overlaps QueryBuilder home-query handling and trimmed vs raw query propagation.

Suggested reviewers

• jjw24
• taooceros

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The PR includes out-of-scope changes beyond the stated objectives: ResultListBox.xaml.cs introduces locking and field renaming changes (_start, _path, _isDragging, _trimmedQuery) unrelated to the Input property addition or issue #2605.	Remove or defer the ResultListBox.xaml.cs locking and field renaming changes to a separate PR focused on that refactoring, keeping this PR focused on adding Input property and fixing update logic.
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.33% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR successfully addresses issue #2605 by adding the Input property to preserve untrimmed query data, allowing developers to access raw user input with whitespace intact as requested.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the rationale for adding OriginalQuery/Input properties, replacing RawQuery with TrimmedQuery, fixing update logic comparisons, and addressing issue #2605.
Title check	✅ Passed	The title accurately captures the two main objectives: improving query result update logic and providing access to the exact query typed by the user through the new Input property.

✨ Finishing touches

• [ ] 📝 Generate docstrings

🧪 Generate unit tests (beta)

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment
• [ ] Commit unit tests in branch improve_update

[!TIP]

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[Jack251970]

@jjw24 ~~I am not sure if this PR can resolve #3508.~~

[jjw24]

Until we can actually figure out what's causing it.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm[bot]]

🥷 Code experts: theClueless

Jack251970 has most 👩‍💻 activity in the files. Jack251970, theClueless have most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/Plugin/QueryBuilder.cs

Activity based on git-commit:

	Jack251970
MAY	3 additions & 3 deletions
APR
MAR
FEB
JAN
DEC

Knowledge based on git-blame: theClueless: 53% Jack251970: 7%

Flow.Launcher.Plugin/Query.cs

Activity based on git-commit:

	Jack251970
MAY	4 additions & 3 deletions
APR
MAR
FEB	6 additions & 6 deletions
JAN	1 additions & 13 deletions
DEC

Knowledge based on git-blame: Jack251970: 11%

Flow.Launcher.Test/QueryBuilderTest.cs

Activity based on git-commit:

	Jack251970
MAY
APR
MAR
FEB	20 additions & 19 deletions
JAN
DEC

Knowledge based on git-blame: theClueless: 57% Jack251970: 31%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970
MAY	0 additions & 4 deletions
APR	69 additions & 45 deletions
MAR	1141 additions & 1076 deletions
FEB	1 additions & 1 deletions
JAN
DEC	5 additions & 10 deletions

Knowledge based on git-blame: Jack251970: 65%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	Jack251970
MAY	171 additions & 75 deletions
APR	35 additions & 28 deletions
MAR	695 additions & 628 deletions
FEB	63 additions & 21 deletions
JAN	17 additions & 21 deletions
DEC	59 additions & 63 deletions

Knowledge based on git-blame: Jack251970: 36%

To learn more about /:\ gitStream - Visit our Docs

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	24
:warning: non-alpha-in-dictionary	13

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[jjw24]

@jjw24 I am not sure if this PR can resolve #3508.

Are you still working on this or is it parked?

[Jack251970]

@jjw24 I am not sure if this PR can resolve #3508.

Are you still working on this or is it parked?

I remembered #3508 is already resolved in previous PR (#3513).

[jjw24]

So do you want to close this or mark craft?

[Jack251970]

sorry, I cannot get it. all works have been done here and it should be ready for review

---Original--- From: "Jeremy @.> Date: Tue, Jun 17, 2025 17:39 PM To: @.>; Cc: "Jack @.@.>; Subject: Re: [Flow-Launcher/Flow.Launcher] Improve update logic & Fix updatelogic issue & Input for Query (PR #3502)

jjw24 left a comment (Flow-Launcher/Flow.Launcher#3502)

So do you want to close this or mark craft?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[jjw24]

Oh ok so these changes are still relevant