ARM64 Build

[taooceros]

[coderabbitai[bot]]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes involve updates to multiple files to support the ARM64 architecture. The Net7.0-SelfContained.pubxml and appveyor.yml files have been modified to target ARM64, reflecting this shift in their respective properties. The GitHub Actions workflow was updated to restrict PR triggers and add caching. Modifications in the Flow.Launcher.csproj file add ARM64-specific property groups. The Explorer plugin was updated with new ARM64-related error messages and conditional compilation checks.

Changes

File	Change Summary
Flow.Launcher/Properties/PublishProfiles/...	Updated <Platform> from Any CPU to ARM64 and <RuntimeIdentifier> from win-x64 to win-arm64.
appveyor.yml	Changed target platform from Any CPU to ARM64; added NuGet restore and a dotnet test command.
.github/workflows/dotnet.yml	Restricted PR triggers to dev and master branches; added NuGet and .NET tools caching steps.
Flow.Launcher/Flow.Launcher.csproj	Added ARM64-specific property groups for Debug and Release configurations with ARM64 constant.
Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml	Added string resource warning that ARM64 is not supported for Everything plugin.
Plugins/Flow.Launcher.Plugin.Explorer/Main.cs	Added #if !ARM64 directive to conditionally load Everything API DLL; minor formatting changes.
Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingSearchManager.cs	Added ARM64 check throwing EngineNotAvailableException; improved method signature formatting.
Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs	Removed an extraneous blank line in a switch statement without logic change.
Directory.Build.props	Added <RuntimeIdentifier> property set to $(FlowRuntimeIdentifier).
Scripts/post_build.ps1	Commented out call to Publish-Portable function, disabling its execution.

Poem

🐰 In fields of code, we hop with glee,
ARM64 awaits, as bright as can be!
With tests that run, our builds take flight,
A leap for the future, oh what a sight!
Through changes we bound, with joy in our hearts,
In the world of tech, a new journey starts! 🌟

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[taooceros]

huh I think the CI is problematic; we need to switch to github action for this https://help.appveyor.com/discussions/questions/62461-build-on-windows-arm64-possible

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[jjw24]

ARM64 Everything SDK dll from https://github.com/Flow-Launcher/Flow.Launcher/pull/2996

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[taooceros]

TODO: add the code related to import arm64 everything dll

[maxnabokow]

@taooceros Thanks for putting this together. Glad we're getting an arm64 build. When can we get this merged and released? What else does the team still need to do?

[taooceros]

@taooceros Thanks for putting this together. Glad we're getting an arm64 build. When can we get this merged and released? What else does the team still need to do?

There are quite a few reason that it is not yet production ready.

1. Our auto-update pipeline does not support multiple update sources (See #2616)
2. Appveyor does not support ARM64, in which is the pipeline we are using. (See #2986 for progress to migrate to github action, and is what is used in this pr).
3. The ARM64 build may have problem interact with some plugins (like everything I haven't finished, and some plugin that published specifically for x64 instead of full platform). We need a good spec to illustrate the platform compatibility.

Those issues are non-trivial, and given that ARM64 users are still small, I would encourage people who wants ARM64 native to download the artifact from this pr.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors	Count
:x: forbidden-pattern	22
:x: ignored-expect-variant	1
:warning: non-alpha-in-dictionary	19

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[kalyway101]

I was able to successfully merge the arm64 changes with the latest dev branch and build it. It works well on my Windows ARM device (Snapdragon Elite). It's very snappy, quicker to launch, and doesn't have any lag that comes when emulating x86 apps/Flow Launcher.

There are issues, which I have not looked into closely, such as problems with the Squirrel Updater when installing, and unable to install plugins from the store (also getting exception errors). Though it seems slightly promising so far.

[taooceros]

I was able to successfully merge the arm64 changes with the latest dev branch and build it. It works well on my Windows ARM device (Snapdragon Elite). It's very snappy, quicker to launch, and doesn't have any lag that comes when emulating x86 apps/Flow Launcher.

There are issues, which I have not looked into closely, such as problems with the Squirrel Updater when installing, and unable to install plugins from the store (also getting exception errors). Though it seems slightly promising so far.

I think we didn't force people to publish plugin with ARM64 versions, which may create some issue. I think we should add a property in plugin.json to specify which platform it supports?

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors and Warnings	Count
:x: forbidden-pattern	14
:warning: non-alpha-in-dictionary	2

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Reject duplicate words

\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[jjw24]

I was able to successfully merge the arm64 changes with the latest dev branch and build it. It works well on my Windows ARM device (Snapdragon Elite). It's very snappy, quicker to launch, and doesn't have any lag that comes when emulating x86 apps/Flow Launcher. There are issues, which I have not looked into closely, such as problems with the Squirrel Updater when installing, and unable to install plugins from the store (also getting exception errors). Though it seems slightly promising so far.

I think we didn't force people to publish plugin with ARM64 versions, which may create some issue. I think we should add a property in plugin.json to specify which platform it supports?

Make it optional and the plugin store will need to be updated to show only the plugins that have this property.

[kalyway101]

I was able to successfully merge the arm64 changes with the latest dev branch and build it. It works well on my Windows ARM device (Snapdragon Elite). It's very snappy, quicker to launch, and doesn't have any lag that comes when emulating x86 apps/Flow Launcher. There are issues, which I have not looked into closely, such as problems with the Squirrel Updater when installing, and unable to install plugins from the store (also getting exception errors). Though it seems slightly promising so far.

I think we didn't force people to publish plugin with ARM64 versions, which may create some issue. I think we should add a property in plugin.json to specify which platform it supports?

Make it optional and the plugin store will need to be updated to show only the plugins that have this property.

This seems like a good compromise to "fix" any plugin compatibilities