Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Quick Adjust Width Size by Ctrl + Plus/Minus

Open onesounds opened this issue 3 years ago • 5 comments

image

  • Quick Adjust Width Size by Ctrl + Plus/Minus in query box.
  • Quick Adjust Max Result Shown by Ctrl + [ , Ctrl + ] in query box.
  • Add Tooltip
  • in this case, user can increase size unlimited. There is only a minimum limit, no maximum limit.

onesounds avatar Sep 07 '22 05:09 onesounds

  • Add Ctrl+F12 to Toggle Game Mode.

onesounds avatar Sep 08 '22 07:09 onesounds

I changed it because it was more intuitive to change it like this.

  • Plus Minus : Max Result
  • square brackets : Width

onesounds avatar Sep 08 '22 09:09 onesounds

@onesounds please take a look on my latest change

taooceros avatar Sep 19 '22 20:09 taooceros

@onesounds please take a look on my latest change

It's well organized and the code works well.

onesounds avatar Sep 20 '22 01:09 onesounds

but why the build faild?

onesounds avatar Sep 21 '22 08:09 onesounds

Are we still using Ctrl+ Arrow keys? If so this may interfere with normal text box shortcuts.

Garulf avatar Sep 21 '22 22:09 Garulf

Are we still using Ctrl+ Arrow keys? If so this may interfere with normal text box shortcuts.

I remove them.

taooceros avatar Sep 21 '22 22:09 taooceros

  1. When you use the shortcut for expanding or shrinking the query window width, the new width doesn't seem to get reflected back in the settings window.
  2. Expanding the width of the query window using the shortcut does not respect the maximum width in the Settings, consequently you can keep expanding the width forever
  3. Using the shortcut to expand the result list doesn't respect the maximum allowed results displayed, consequently can keep expanding forever.

jjw24 avatar Oct 10 '22 02:10 jjw24

  1. When you use the shortcut for expanding or shrinking the query window width, the new width doesn't seem to get reflected back in the settings window.
  2. Expanding the width of the query window using the shortcut does not respect the maximum width in the Settings, consequently you can keep expanding the width forever
  3. Using the shortcut to expand the result list doesn't respect the maximum allowed results displayed, consequently can keep expanding forever.

Fixed

onesounds avatar Oct 10 '22 06:10 onesounds

Need to make sure the subtitle sentence is appropriate. @Garulf

onesounds avatar Oct 10 '22 06:10 onesounds

Need to make sure the subtitle sentence is appropriate. @Garulf

Updated the wording, hopefully ok.

jjw24 avatar Oct 14 '22 10:10 jjw24

@taooceros What's this change for us specifically?

I couldn't reply directly. This is a workaround for source generator. Details here https://github.com/dotnet/wpf/issues/6792.

If that's being fixed, we can remove it.

taooceros avatar Oct 14 '22 23:10 taooceros

@taooceros What's this change for us specifically?

I couldn't reply directly. This is a workaround for source generator. Details here dotnet/wpf#6792.

If that's being fixed, we can remove it.

I think it is fixed (in 6.0.400+). However it seems that appveyor hasn't got the latest image. Let's wait a while later.

taooceros avatar Oct 14 '22 23:10 taooceros

Technically it's Ctrl + "=" and Ctrl + "-".

VictoriousRaptor avatar Oct 17 '22 08:10 VictoriousRaptor

👍 https://github.com/Flow-Launcher/Flow.Launcher/pull/1480

jjw24 avatar Oct 17 '22 20:10 jjw24

@jjw24 @VictoriousRaptor

You guys are too programmers. Why don't you consider the average user? This is my intended to make it easier for the general user to memorize hotkey. I changed the shortcut once in the middle for this PR.

+:increase count. -: decrease count. [ : decrease size ] : increase size

It is a key chosen so that it can be intuitively understood.

"Technically it's Ctrl + "=" and Ctrl + "-"." <- This can be talked about. This is because it is not a strong suggestion. "OK I changed it" <- NOoooooooo

image

Photoshop. They are not idiots who don't even know the keycode.

image memopad

image firefox

I have never seen a case of writing = and - instead of + and - when matching these shortcuts. What stupid program writes shortcuts like this? flow launcher? 😂

onesounds avatar Oct 18 '22 01:10 onesounds

Lol looking at those screenshots, realised I never paid much attention to how those shortcuts are described, makes sense. Let's revert it back.

jjw24 avatar Oct 18 '22 02:10 jjw24

In fact I found it when was looking at my keyboard and realized that + needs a shift combined to input. And I opened powertoys,tried adding some hotykeys, found that they use "=" to describe that key. And I thought every software use "=". Really never paid attention to that.

VictoriousRaptor avatar Oct 18 '22 02:10 VictoriousRaptor

good. You guys sins are forgiven.

onesounds avatar Oct 18 '22 02:10 onesounds

So maybe for a single key, = is correct but for pairs like our new shortcut, + and - is a more user friendly choice.

VictoriousRaptor avatar Oct 18 '22 02:10 VictoriousRaptor