Merge Explorer & Everything Plugins

[taooceros]

1. Shared Interface for Windows Index and Everything Index
2. Settings Merge (Part 1)
3. Include Everything dll

TODO:

• [x] finish Path traversal unify
• [x] implement Engine selection
• [x] #526
• [x] #646
• [x] implement Everything auto download
• [ ] Context Menu for windows (ported from everything)

[taooceros]

Thinking about enumeration design. Probably it would be better to only use index search when doing recursive search for enumerating a directory, and do a direct search when only traverse the first level. @jjw24 what do you think

[jjw24]

I think directory recursive search with Windows Search could be restricted by user's indexing options/excluded directories, so allowing an option to use DirectoryInfo search method is preferred per current design in this area.

What do you mean by direct search when only traverse the first leve?

[taooceros]

I think directory recursive search with Windows Search could be restricted by user's indexing options/excluded directories, so allowing an option to use DirectoryInfo search method is preferred per current design in this area.

What do you mean by direct search when only traverse the first leve?

oh I mean we may always use the DirectoryInfo Search for the non-recursive traversal.

[taooceros]

@onesounds mind creating a engine selection ui for this? I am not sure whether it is a good practice to use interface for purpose selection, but probably we can adjust that easier.

• IndexSearchEngine
  • WindowsIndex
  • Everything
• ContentSearchEngine
  • WindowsIndex
  • Everything
• PathEnumerator
  • Direct
  • WindowsIndex
  • Everything

[taooceros]

@Flow-Launcher/team I have almost finished most features and the UI Refactor. There're some small features in everything plugin that I haven't ported, but it will be fairly easy to do so. Anyone want to give this pr a check?

[taooceros]

@jjw24 feel free to review. The remaining part is only about everything's translation, and I will try to fix it through crowdin recently.

[jjw24]

Could you fix the build failure please :)

[jjw24]

I haven't had a chance to look at the code yet but just thought of something- have you added handling of situation where user already has Everything service/plugin installed?

[taooceros]

I haven't had a chance to look at the code yet but just thought of something- have you added handling of situation where user already has Everything service/plugin installed?

not for everything plugin. For everything service, I just copied the code from everything plugin, so as long as it is handled there, we are fine.

[taooceros]

I will fix the conflict tmr.

[jjw24]

@taooceros could you please fix the CI

[jjw24]

Couple of things:

1. Path search seems to be always using index search, 'Use Index Search For Path Search' unticked and selecting 'Direct Enumeration' do nothing.

2. Please complete Everything's translation, the keys should at least exist.

3. Selecting Everything should prompt user if they want to download and install Everything, when 'Yes' flow should automatically download and install it.

4. Clicking on the plugin's settings:

5. What is 'Launch Hidden' and I remember it's part of Everything plugin? Should move to the Everything setting tab if the case.

6. Using 'Index Search Excluded Path' is not working, could be same issue as point 1.

[jjw24]

@taooceros please update description on what you have tested.

[onesounds]

Fix https://github.com/Flow-Launcher/Flow.Launcher/issues/1495

[taooceros]

Couple of things:

1. Path search seems to be always using index search, 'Use Index Search For Path Search' unticked and selecting 'Direct Enumeration' do nothing.

It works, but the path equality check have some issue due to previous change to make subtitle only display parent path, which makes everything duplicate except the first one. fixed.

2. Please complete Everything's translation, the keys should at least exist.

Fixed

3. Selecting Everything should prompt user if they want to download and install Everything, when 'Yes' flow should automatically download and install it.

I think we can do it when user actually search (when the result display everything not working).

4. Clicking on the plugin's settings:
   ![image](https://user-images.githubusercontent.com/26427004/201588745-4b0b8eff-eb0d-4547-b1bb-126cc103ba8b.png)

I cannot reproduce

5. What is 'Launch Hidden' and I remember it's part of Everything plugin? Should move to the Everything setting tab if the case.

This is a weird setting and I think we have made the decision to remove it.

6. Using 'Index Search Excluded Path' is not working, could be same issue as point 1.

~~Will handle that soon.~~

Fixed

[jjw24]

Translations are done?

[jjw24]

Getting this error when clicking on plugin settings from the plugins tab

[jjw24]

5. What is 'Launch Hidden' and I remember it's part of Everything plugin? Should move to the Everything setting tab if the case. This is a weird setting and I think we have made the decision to remove it.

Please remove it.

[jjw24]

Shouldn't these settings be moved to Everything settings tab?

[taooceros]

Shouldn't these settings be moved to Everything settings tab?

No they are general. I don't think there's a specific reason that we only apply them to everything unless we think they should not be included.

[taooceros]

3. Selecting Everything should prompt user if they want to download and install Everything, when 'Yes' flow should automatically download and install it.

This is still not fixed. Using Everything engine for index search/content search without everything installed just errors out:

Very weird I do have tested that without everything install a custom exception will be thrown and caught in a different way. This is the intended result (the icon has been changed to an error icon)

[taooceros]

will check that later today

[jjw24]

Could this be Everything is installed but not running?

[taooceros]

Could this be Everything is installed but not running?

I do haven't uninstalled everything, but I believe both should throw IPCError? Not so sure why it may be different. Will check tongiht

[jjw24]

Changing action keywords do not take effect on first try. Repro: Remove the settings.json file in user data directory. Start up flow, go to Explorer and change Path action keyword. Trigger the keyword and it does not happen. Only after changing the action keyword again then it will trigger.

[jjw24]

Please address:

1. When Everything is selected as Index Search Engine, press and hold any key will cause below error:

2. Bring this message back when Windows Index is disabled:

3. Hide the search window when the prompt to install Everything is shown:

4. Please add icon for this result:

[jjw24]

Please address:

1. When Everything is selected as Index Search Engine, press and hold any key will cause below error:
2. Bring this message back when Windows Index is disabled:
3. Hide the search window when the prompt to install Everything is shown:
4. Please add icon for this result:

@taooceros I am fixing 2,3,4

[taooceros]

the concurrency bug is ....very weird but interesting (I know what's causing it, and try to find a good solution). Basically the Wait is cancelled so the semaphore count is not reduced, but the finally block release it.