dataslate icon indicating copy to clipboard operation
dataslate copied to clipboard

Roster files without extensions don't display anything

Open TimothyHD opened this issue 3 years ago • 7 comments

When I load a .rosz file nothing happens.

TimothyHD avatar Jul 21 '22 15:07 TimothyHD

That's strange! Is it a valid Kill Team roster? Could you attach it here so I can take a look?

Floppy avatar Jul 21 '22 20:07 Floppy

Both of these worked on datacard.app. I like things about your format though

On Thu, Jul 21, 2022 at 3:25 PM James Smith @.***> wrote:

That's strange! Is it a valid Kill Team roster? Could you attach it here so I can take a look?

— Reply to this email directly, view it on GitHub https://github.com/Floppy/dataslate/issues/890#issuecomment-1191899892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEAWSGLHLDT4ZJKAIIHRQMLVVGWZXANCNFSM54IAYSLA . You are receiving this because you authored the thread.Message ID: @.***>

TimothyHD avatar Jul 22 '22 16:07 TimothyHD

I can't see any files attached, wondering if github doesn't attach from email? Can you go to the issue on GitHub and attach to a comment?

I think error handling is something we can do better in Dataslate, it tends to just silently fail and not give any indication of what has happened if there's something it had an issue with in the roster file.

g3rg avatar Jul 23 '22 00:07 g3rg

Thanks! I had a go, and indeed nothing happens. However, I noticed the files don't have an extension, and when I add a .ros or .rosz extension, it works fine! So, I guess something in Dataslate is relying on the extension being correct, which I guess it doesn't really need to.

Floppy avatar Jul 24 '22 22:07 Floppy

You beat me to it by seconds @Floppy, was about to post pretty much the same thing.

@TimothyHD out of interest, do you know how the files ended up without the extension?

g3rg avatar Jul 24 '22 22:07 g3rg

I created them on my phone then uploaded to Drive. Could have been either of those steps.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: g3rg @.> Sent: Sunday, July 24, 2022 5:48:38 PM To: Floppy/dataslate @.> Cc: TimothyHD @.>; Mention @.> Subject: Re: [Floppy/dataslate] Roster files without extensions don't display anything (Issue #890)

You beat me to it by seconds @Floppyhttps://github.com/Floppy, was about to post pretty much the same thing.

@TimothyHDhttps://github.com/TimothyHD out of interest, do you know how the files ended up without the extension?

— Reply to this email directly, view it on GitHubhttps://github.com/Floppy/dataslate/issues/890#issuecomment-1193409161, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEAWSGMHY547XFBSVCFWQZ3VVXB4NANCNFSM54IAYSLA. You are receiving this because you were mentioned.Message ID: @.***>

TimothyHD avatar Jul 24 '22 23:07 TimothyHD