dataslate
dataslate copied to clipboard
Floppy
Roster selection
Detect and display roster from BattleScribe file. Allow selecting / deselecting of operatives, which in turn hides the data cards.
@g3rg Since the PR is in draft mode, is it not finished yet? Should I wait with reviewing?
@g3rg Since the PR is in draft mode, is it not finished yet? Should I wait with reviewing?
I'm keen to get the review, but not just of the code, also around usability / usefulness. For printing data cards the roster selection is useful, however with how roster files work in Battlescribe, there's no equipment or fireteam/archetype information, so I guess I'm also asking if this should be merged/deployed before it is determined how that should work.
Looks like some of the latest dependency bumps or lint related changes may have broken the tests.
OK, main is green now, if you rebase then that should solve the test failures. Sorry about that!
Ok, I had a chance to open and run this finally. It's not a feature I'd be using. I am not quite sure what's the idea behind it, so I'm unsure what advice I can give :thinking:
As a person who would not use it I'd make it opt-in. Make it only show after checking a checkbox in settings, perhaps?
Ok, I had a chance to open and run this finally. It's not a feature I'd be using. I am not quite sure what's the idea behind it, so I'm unsure what advice I can give 🤔
As a person who would not use it I'd make it opt-in. Make it only show after checking a checkbox in settings, perhaps?
The eventual idea would be have your 20 model roster, then be able to select fireteams, then the models, then equipment. But as mentioned, that will be a bit of a change for dataslate to have more and more of the KT rules built in. I'm happy to put a setting in to turn it on, especially when in a WIP state, though it also only shows when you build a roster in Battlescribe, as opposed to actual kill team.
As per the discord discussion, I'll leave this as draft, and continue working on it in the background till its useable and useful. No need to review, though comments on how it might work are appreciated.