polymerfire icon indicating copy to clipboard operation
polymerfire copied to clipboard

Polymer 3.0 support

Open kroupacz opened this issue 8 years ago • 17 comments
trafficstars

Hello, Is there an estimated time when we could expect a new version of polymerfire which will be built according to the new Polymer 3.0 standard and stored in NPM?

kroupacz avatar Aug 23 '17 09:08 kroupacz

I would like to try creating a PR over the week and see if it is going to be merged.

tjmonsi avatar Sep 02 '17 10:09 tjmonsi

Oh wait... it uses some sort of builder. I think the Polymer team has that builder that auto-updates it to Polymer 3.0 standards...

tjmonsi avatar Sep 09 '17 23:09 tjmonsi

This element will be auto-upgraded once the modulizer is more robust.

TimvdLippe avatar Sep 15 '17 21:09 TimvdLippe

Hi, when polymerfire will publish to npm ?

jukbot avatar Nov 14 '17 03:11 jukbot

I took a look at this trying to modify and ran into issues. The modulizer didn't transform the hybrid polymer elements so the code would need to be updated to the class syntax for modulizer. However after conversion I had an issue importing the firebase code. It's using a global variable (firebase) which works fine for HTML imports but with modules that value wasn't being pulled in with imports. The firebase code isn't exporting anything for ES2015 modules to use. Without a build tool I wasn't sure how to proceed from there especially in regards to using only specific components.

Mash19 avatar Nov 15 '17 00:11 Mash19

Although I would love to just use the modulizer. I have to review the whole code (and might do a re-write of some parts). Given that the modulizer is still in its alpha-stage, and have some problems... I don't have a better idea on what's the best alternative.

I also want to think if it is possible to rewrite the behaviors to mixins and add a Firestore behavior for backwards compat.

tjmonsi avatar Feb 21 '18 11:02 tjmonsi

Any update on this folks? Not long until the end of Q1 (aka 3.0 launch).

Does the current build work in a 3.0 project?

davie-robertson avatar Mar 20 '18 12:03 davie-robertson

Polymer 3.0 has officially launched now.

Unfortunately, the modulizer still isn't "finished", but it's far enough along that they encourage people to try using it on their codebase. The expectation is that either

  • it works for your code base
  • it gets you most of the way there and you can do the rest by hand

or in the worst case

  • finds bugs or edge cases that can be reported upstream.

Has anyone attempted the conversion since @Mash19 in November? It seems like a good time to give it another shot, and if it still doesn't work, report issues upstream.

zevdg avatar May 10 '18 18:05 zevdg

We should probably just make a PR. I made a WIP PR (#344) against firestore branch since it is the most important part for me.

Can we split the work somehow?

merlinnot avatar May 10 '18 20:05 merlinnot

@zevdg I just tried running the modulizer on the project and it produced the same thing (as far as I can tell) as what @Mash19 reported. It converts the imports, but not the Polymer(); call.

adueppen avatar May 16 '18 23:05 adueppen

Modulizer won't do everything for us. It just requires some manual work to make it Polymer 3 - compatible.

merlinnot avatar May 16 '18 23:05 merlinnot

Hi

I'm new to polymer, and planning to use in a new project and that will use firebase too, on reasearch I found this issue, any thing to worry? or its ok to use Firebase Javascript SDK until you got back polymerfire working? or for now better use version 2.0 then migrate to 3.0 when all things are solved for last version?

cwichoski avatar May 30 '18 01:05 cwichoski

@cwichoski If you start a new project with polymer 3, it's probably simpler to use the normale firebase SDK instead of polymerfire. Since the developer experience of Polymer 3 (with LitElement) and React are now practically identical, I would have a look at React + Firebase documentation.

BrandiATMuhkuh avatar May 31 '18 16:05 BrandiATMuhkuh

@Mash19 @merlinnot have you guys had any luck with this?

intcreator avatar Jun 22 '18 04:06 intcreator

That's the current status: @intcreator https://github.com/firebase/polymerfire/issues/353

merlinnot avatar Jun 22 '18 08:06 merlinnot

Try https://github.com/iceflow19/polymerfire works for me, including geofire

mmikrut avatar Mar 05 '19 22:03 mmikrut

https://www.npmjs.com/package/polymerfire3 Hope it helps you :)

LeongTitanFour avatar Sep 28 '19 17:09 LeongTitanFour