polymerfire icon indicating copy to clipboard operation
polymerfire copied to clipboard

solve 0 key see as no key

Open arfost opened this issue 9 years ago • 9 comments

Actualy when a key is set to 0, the firebase-document think that there is no key, but firebase can self generate key at 0 from array, and the concerned item will be untouchable.

arfost avatar Nov 03 '16 15:11 arfost

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Nov 03 '16 15:11 googlebot

I signed it!

arfost avatar Nov 03 '16 15:11 arfost

CLAs look good, thanks!

googlebot avatar Nov 03 '16 15:11 googlebot

Can you also add a breaking test case that is fixed by your PR?

mbleigh avatar Nov 03 '16 18:11 mbleigh

Thanks for the answer, I did the check change, for the test i'm still new to polymer and firebase, and not exactly sure on how to do it for now. I'll look it up tonight to learn and will do it tomorrow if i think i'm good to go or ask for help if not :)

arfost avatar Nov 03 '16 19:11 arfost

Ok, I looked into the test things, and I'm not sure of what I have to do. It seems that the firebase-document tests are from an external lib. Should I modify this external file or add a single test in the firebase-document test file ? Or am I way out, and it's something totally different ?

arfost avatar Nov 04 '16 11:11 arfost

@arfost You add firebase-document test file in the tests directory

justweb1 avatar May 25 '17 03:05 justweb1

I think we can add a test later? I'm going to check up on this, this weekend

tjmonsi avatar Sep 21 '17 17:09 tjmonsi

I’ll add a test for this in the coming days so we can proceed. I’d also like to revert the change requested by @mbleigh per https://github.com/firebase/polymerfire/pull/142#discussion_r159987448

Is it ok?

merlinnot avatar Jan 05 '18 21:01 merlinnot